Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: src/compiler/escape-analysis.cc

Issue 2861143002: Fix tracing in escape-analysis.cc. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/escape-analysis.cc
diff --git a/src/compiler/escape-analysis.cc b/src/compiler/escape-analysis.cc
index 8f344fedc14ad1579146e7f5992d818816d42d02..b6d2e019394ba811b912a01d52d6854a0c093e35 100644
--- a/src/compiler/escape-analysis.cc
+++ b/src/compiler/escape-analysis.cc
@@ -168,7 +168,8 @@ class VirtualObject : public ZoneObject {
bool IsCreatedPhi(size_t offset) { return phi_[offset]; }
void SetField(size_t offset, Node* node, bool created_phi = false) {
- TRACE(" VirtualObject(%p)[%zu] changes from #%i to #%i\n", this, offset,
+ TRACE(" VirtualObject(%p)[%zu] changes from #%i to #%i\n",
+ static_cast<void*>(this), offset,
fields_[offset] ? fields_[offset]->id() : -1, node ? node->id() : -1);
fields_[offset] = node;
phi_[offset] = created_phi;
@@ -236,7 +237,8 @@ class VirtualObject : public ZoneObject {
DEFINE_OPERATORS_FOR_FLAGS(VirtualObject::StatusFlags)
bool VirtualObject::UpdateFrom(const VirtualObject& other) {
- TRACE("%p.UpdateFrom(%p)\n", this, &other);
+ TRACE("%p.UpdateFrom(%p)\n", static_cast<void*>(this),
+ static_cast<const void*>(&other));
bool changed = status_ != other.status_;
status_ = other.status_;
phi_ = other.phi_;
@@ -1253,9 +1255,10 @@ void EscapeAnalysis::ForwardVirtualState(Node* node) {
DCHECK_NOT_NULL(virtual_states_[effect->id()]);
if (virtual_states_[node->id()]) {
TRACE("Updating virtual state %p at %s#%d from virtual state %p at %s#%d\n",
- virtual_states_[node->id()], node->op()->mnemonic(), node->id(),
- virtual_states_[effect->id()], effect->op()->mnemonic(),
- effect->id());
+ static_cast<void*>(virtual_states_[node->id()]),
+ node->op()->mnemonic(), node->id(),
+ static_cast<void*>(virtual_states_[effect->id()]),
+ effect->op()->mnemonic(), effect->id());
virtual_states_[node->id()]->UpdateFrom(virtual_states_[effect->id()],
zone());
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698