Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4160)

Unified Diff: base/trace_event/process_memory_dump_unittest.cc

Issue 2861133002: memory-infra: Move dump level check to observer and rename session state (Closed)
Patch Set: move comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/process_memory_dump_unittest.cc
diff --git a/base/trace_event/process_memory_dump_unittest.cc b/base/trace_event/process_memory_dump_unittest.cc
index 4ee6508190c14048f3a0899b4e24917e65bf52eb..70f897c6b39dcc047e7de11a5a92206a944542e1 100644
--- a/base/trace_event/process_memory_dump_unittest.cc
+++ b/base/trace_event/process_memory_dump_unittest.cc
@@ -94,22 +94,22 @@ TEST(ProcessMemoryDumpTest, TakeAllDumpsFrom) {
metrics_by_context[AllocationContext()] = { 1, 1 };
TraceEventMemoryOverhead overhead;
- scoped_refptr<MemoryDumpSessionState> session_state =
- new MemoryDumpSessionState;
- session_state->SetStackFrameDeduplicator(
+ scoped_refptr<HeapProfilerSerializationState>
+ heap_profiler_serialization_state = new HeapProfilerSerializationState;
+ heap_profiler_serialization_state->SetStackFrameDeduplicator(
WrapUnique(new StackFrameDeduplicator));
- session_state->SetTypeNameDeduplicator(
+ heap_profiler_serialization_state->SetTypeNameDeduplicator(
WrapUnique(new TypeNameDeduplicator));
- std::unique_ptr<ProcessMemoryDump> pmd1(
- new ProcessMemoryDump(session_state.get(), kDetailedDumpArgs));
+ std::unique_ptr<ProcessMemoryDump> pmd1(new ProcessMemoryDump(
+ heap_profiler_serialization_state.get(), kDetailedDumpArgs));
auto* mad1_1 = pmd1->CreateAllocatorDump("pmd1/mad1");
auto* mad1_2 = pmd1->CreateAllocatorDump("pmd1/mad2");
pmd1->AddOwnershipEdge(mad1_1->guid(), mad1_2->guid());
pmd1->DumpHeapUsage(metrics_by_context, overhead, "pmd1/heap_dump1");
pmd1->DumpHeapUsage(metrics_by_context, overhead, "pmd1/heap_dump2");
- std::unique_ptr<ProcessMemoryDump> pmd2(
- new ProcessMemoryDump(session_state.get(), kDetailedDumpArgs));
+ std::unique_ptr<ProcessMemoryDump> pmd2(new ProcessMemoryDump(
+ heap_profiler_serialization_state.get(), kDetailedDumpArgs));
auto* mad2_1 = pmd2->CreateAllocatorDump("pmd2/mad1");
auto* mad2_2 = pmd2->CreateAllocatorDump("pmd2/mad2");
pmd2->AddOwnershipEdge(mad2_1->guid(), mad2_2->guid());

Powered by Google App Engine
This is Rietveld 408576698