Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: base/trace_event/memory_tracing_observer.h

Issue 2861133002: memory-infra: Move dump level check to observer and rename session state (Closed)
Patch Set: move comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_tracing_observer.h
diff --git a/base/trace_event/memory_tracing_observer.h b/base/trace_event/memory_tracing_observer.h
index 1efea18c4d552509fa5d2c59c0015f165a287a28..11276763c1a7829374c23860116fa765432ec7ef 100644
--- a/base/trace_event/memory_tracing_observer.h
+++ b/base/trace_event/memory_tracing_observer.h
@@ -33,8 +33,12 @@ class BASE_EXPORT MemoryTracingObserver
const ProcessMemoryDump*);
private:
+ // Returns true if the dump mode is allowed for current tracing session.
+ bool IsDumpModeAllowed(MemoryDumpLevelOfDetail) const;
+
MemoryDumpManager* const memory_dump_manager_;
TraceLog* const trace_log_;
+ std::unique_ptr<TraceConfig::MemoryDumpConfig> memory_dump_config_;
DISALLOW_COPY_AND_ASSIGN(MemoryTracingObserver);
};

Powered by Google App Engine
This is Rietveld 408576698