Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc

Issue 2861063003: Remove dangerous CanonicalCookie::Create method. (Closed)
Patch Set: Use creation_time for last_access_time as per Elly's suggestion. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_store_unittest.h ('k') | net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
diff --git a/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc b/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
index f73ba2f8d48c0d84be2d19e982c0a354d02f7744..e9b0ef2b17737e2cb873bb763c831ede1011b109 100644
--- a/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
+++ b/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
@@ -77,12 +77,11 @@ class SQLitePersistentCookieStorePerfTest : public testing::Test {
base::Time t = base::Time::Now();
for (int domain_num = 0; domain_num < 300; domain_num++) {
std::string domain_name(base::StringPrintf(".domain_%d.com", domain_num));
- GURL gurl("http://www" + domain_name);
for (int cookie_num = 0; cookie_num < 50; ++cookie_num) {
t += base::TimeDelta::FromInternalValue(10);
store_->AddCookie(*CanonicalCookie::Create(
- gurl, base::StringPrintf("Cookie_%d", cookie_num), "1", domain_name,
- "/", t, t, false, false, CookieSameSite::DEFAULT_MODE,
+ base::StringPrintf("Cookie_%d", cookie_num), "1", domain_name, "/",
+ t, t, t, false, false, CookieSameSite::DEFAULT_MODE,
COOKIE_PRIORITY_DEFAULT));
}
}
« no previous file with comments | « net/cookies/cookie_store_unittest.h ('k') | net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698