Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: net/cookies/cookie_monster_store_test.cc

Issue 2861063003: Remove dangerous CanonicalCookie::Create method. (Closed)
Patch Set: Incorporated all comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cookies/cookie_monster_store_test.cc
diff --git a/net/cookies/cookie_monster_store_test.cc b/net/cookies/cookie_monster_store_test.cc
index 558d4bc02c3dd500a2c6b47037fb9bd2b04c2106..34fb81db729cd68495146656dce3786881f61836 100644
--- a/net/cookies/cookie_monster_store_test.cc
+++ b/net/cookies/cookie_monster_store_test.cc
@@ -130,10 +130,10 @@ std::unique_ptr<CanonicalCookie> BuildCanonicalCookie(
: base::Time();
std::string cookie_path = pc.Path();
- return CanonicalCookie::Create(url, pc.Name(), pc.Value(), url.host(),
+ return CanonicalCookie::Create(pc.Name(), pc.Value(), "." + url.host(),
cookie_path, creation_time, cookie_expires,
- pc.IsSecure(), pc.IsHttpOnly(), pc.SameSite(),
- pc.Priority());
+ base::Time(), pc.IsSecure(), pc.IsHttpOnly(),
+ pc.SameSite(), pc.Priority());
}
void AddCookieToList(const GURL& url,
@@ -239,8 +239,8 @@ std::unique_ptr<CookieMonster> CreateMonsterFromStoreForGC(
// strict secure cookies are enforced, the cookie will fail to be created if
// |secure| is true but the URL is an insecure scheme.
std::unique_ptr<CanonicalCookie> cc(CanonicalCookie::Create(
- GURL(base::StringPrintf("https://h%05d.izzle/", i)), "a", "1",
- std::string(), "/path", creation_time, expiration_time, secure, false,
+ "a", "1", base::StringPrintf("h%05d.izzle", i), "/path", creation_time,
+ expiration_time, base::Time(), secure, false,
CookieSameSite::DEFAULT_MODE, COOKIE_PRIORITY_DEFAULT));
cc->SetLastAccessDate(last_access_time);
store->AddCookie(*cc);

Powered by Google App Engine
This is Rietveld 408576698