Chromium Code Reviews

Unified Diff: ios/net/cookies/cookie_cache_unittest.cc

Issue 2861063003: Remove dangerous CanonicalCookie::Create method. (Closed)
Patch Set: Fixed bugs from DCHECKing name & path. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: ios/net/cookies/cookie_cache_unittest.cc
diff --git a/ios/net/cookies/cookie_cache_unittest.cc b/ios/net/cookies/cookie_cache_unittest.cc
index a3438ae44992233d9dc7c27bb80ab38e44e2c5e5..f875004cf7707eec773aa677d29fae390adfb156 100644
--- a/ios/net/cookies/cookie_cache_unittest.cc
+++ b/ios/net/cookies/cookie_cache_unittest.cc
@@ -17,10 +17,10 @@ namespace {
CanonicalCookie MakeCookie(const GURL& url,
const std::string& name,
const std::string& value) {
- return *CanonicalCookie::Create(url, name, value, std::string(), url.path(),
- base::Time(), base::Time(), false, false,
- net::CookieSameSite::DEFAULT_MODE,
- net::COOKIE_PRIORITY_DEFAULT);
+ return *CanonicalCookie::Create(
+ name, value, url.host(), url.path(), base::Time(), base::Time(),
+ base::Time(), false, false, net::CookieSameSite::DEFAULT_MODE,
+ net::COOKIE_PRIORITY_DEFAULT);
}
} // namespace

Powered by Google App Engine