third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js - Issue 2861053003: DevTools: [lighthouse] Implement performance metrics filmstrip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js

Issue 2861053003: DevTools: [lighthouse] Implement performance metrics filmstrip (Closed)

Patch Set: test fixed Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/audits2/module.json ('k') | third_party/WebKit/Source/devtools/front_end/emulation/InspectedPagePlaceholder.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js b/third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js

index be5ba325895f36b88bb204dbcbfe4ee056644757..4bdeda200762107ae1e04aae797394445b6b7047 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js

@@ -33,7 +33,7 @@ Emulation.AdvancedApp = class {

this._rootSplitWidget.setDefaultFocusedChild(UI.inspectorView);

UI.inspectorView.setOwnerSplit(this._rootSplitWidget);

- this._inspectedPagePlaceholder = new Emulation.InspectedPagePlaceholder();

+ this._inspectedPagePlaceholder = Emulation.InspectedPagePlaceholder.instance();

this._inspectedPagePlaceholder.addEventListener(

Emulation.InspectedPagePlaceholder.Events.Update, this._onSetInspectedPageBounds.bind(this), this);

this._deviceModeView = new Emulation.DeviceModeWrapper(this._inspectedPagePlaceholder);