chrome/browser/devtools/devtools_ui_bindings.h - Issue 2861053003: DevTools: [lighthouse] Implement performance metrics filmstrip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.h

Issue 2861053003: DevTools: [lighthouse] Implement performance metrics filmstrip (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_ui_bindings.h

diff --git a/chrome/browser/devtools/devtools_ui_bindings.h b/chrome/browser/devtools/devtools_ui_bindings.h

index a27857255f91be094d9792721a02563d5a54a278..bf600542b39a182f6026cdfdebd44cc013f6a0c2 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.h

+++ b/chrome/browser/devtools/devtools_ui_bindings.h

@@ -52,7 +52,7 @@ class DevToolsUIBindings : public DevToolsEmbedderMessageDispatcher::Delegate,

virtual void ActivateWindow() = 0;

virtual void CloseWindow() = 0;

virtual void Inspect(scoped_refptr<content::DevToolsAgentHost> host) = 0;

- virtual void SetInspectedPageBounds(const gfx::Rect& rect) = 0;

+ virtual void SetInspectedPageBounds(const gfx::Rect& rect, bool force) = 0;

virtual void InspectElementCompleted() = 0;

virtual void SetIsDocked(bool is_docked) = 0;

virtual void OpenInNewTab(const std::string& url) = 0;

@@ -98,7 +98,7 @@ class DevToolsUIBindings : public DevToolsEmbedderMessageDispatcher::Delegate,

void ActivateWindow() override;

void CloseWindow() override;

void LoadCompleted() override;

- void SetInspectedPageBounds(const gfx::Rect& rect) override;

+ void SetInspectedPageBounds(const gfx::Rect& rect, bool force) override;

void InspectElementCompleted() override;

void InspectedURLChanged(const std::string& url) override;

void LoadNetworkResource(const DispatchCallback& callback,