Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2861053003: DevTools: [lighthouse] Implement performance metrics filmstrip (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/devtools_ui_bindings.h" 5 #include "chrome/browser/devtools/devtools_ui_bindings.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 public: 197 public:
198 explicit DefaultBindingsDelegate(content::WebContents* web_contents) 198 explicit DefaultBindingsDelegate(content::WebContents* web_contents)
199 : web_contents_(web_contents) {} 199 : web_contents_(web_contents) {}
200 200
201 private: 201 private:
202 ~DefaultBindingsDelegate() override {} 202 ~DefaultBindingsDelegate() override {}
203 203
204 void ActivateWindow() override; 204 void ActivateWindow() override;
205 void CloseWindow() override {} 205 void CloseWindow() override {}
206 void Inspect(scoped_refptr<content::DevToolsAgentHost> host) override {} 206 void Inspect(scoped_refptr<content::DevToolsAgentHost> host) override {}
207 void SetInspectedPageBounds(const gfx::Rect& rect) override {} 207 void SetInspectedPageBounds(const gfx::Rect& rect, bool force) override {}
208 void InspectElementCompleted() override {} 208 void InspectElementCompleted() override {}
209 void SetIsDocked(bool is_docked) override {} 209 void SetIsDocked(bool is_docked) override {}
210 void OpenInNewTab(const std::string& url) override; 210 void OpenInNewTab(const std::string& url) override;
211 void SetWhitelistedShortcuts(const std::string& message) override {} 211 void SetWhitelistedShortcuts(const std::string& message) override {}
212 void SetEyeDropperActive(bool active) override {} 212 void SetEyeDropperActive(bool active) override {}
213 void OpenNodeFrontend() override {} 213 void OpenNodeFrontend() override {}
214 using DispatchCallback = 214 using DispatchCallback =
215 DevToolsEmbedderMessageDispatcher::Delegate::DispatchCallback; 215 DevToolsEmbedderMessageDispatcher::Delegate::DispatchCallback;
216 216
217 void InspectedContentsClosing() override; 217 void InspectedContentsClosing() override;
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 } 661 }
662 662
663 void DevToolsUIBindings::CloseWindow() { 663 void DevToolsUIBindings::CloseWindow() {
664 delegate_->CloseWindow(); 664 delegate_->CloseWindow();
665 } 665 }
666 666
667 void DevToolsUIBindings::LoadCompleted() { 667 void DevToolsUIBindings::LoadCompleted() {
668 FrontendLoaded(); 668 FrontendLoaded();
669 } 669 }
670 670
671 void DevToolsUIBindings::SetInspectedPageBounds(const gfx::Rect& rect) { 671 void DevToolsUIBindings::SetInspectedPageBounds(const gfx::Rect& rect,
672 delegate_->SetInspectedPageBounds(rect); 672 bool force) {
673 delegate_->SetInspectedPageBounds(rect, force);
673 } 674 }
674 675
675 void DevToolsUIBindings::SetIsDocked(const DispatchCallback& callback, 676 void DevToolsUIBindings::SetIsDocked(const DispatchCallback& callback,
676 bool dock_requested) { 677 bool dock_requested) {
677 delegate_->SetIsDocked(dock_requested); 678 delegate_->SetIsDocked(dock_requested);
678 callback.Run(nullptr); 679 callback.Run(nullptr);
679 } 680 }
680 681
681 void DevToolsUIBindings::InspectElementCompleted() { 682 void DevToolsUIBindings::InspectElementCompleted() {
682 delegate_->InspectElementCompleted(); 683 delegate_->InspectElementCompleted();
(...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after
1372 void DevToolsUIBindings::FrontendLoaded() { 1373 void DevToolsUIBindings::FrontendLoaded() {
1373 if (frontend_loaded_) 1374 if (frontend_loaded_)
1374 return; 1375 return;
1375 frontend_loaded_ = true; 1376 frontend_loaded_ = true;
1376 1377
1377 // Call delegate first - it seeds importants bit of information. 1378 // Call delegate first - it seeds importants bit of information.
1378 delegate_->OnLoadCompleted(); 1379 delegate_->OnLoadCompleted();
1379 1380
1380 AddDevToolsExtensionsToClient(); 1381 AddDevToolsExtensionsToClient();
1381 } 1382 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698