ui/events/x/events_x.cc - Issue 286103004: Blocked volume up/down events that originated from remapped function keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/x/events_x.cc

Issue 286103004: Blocked volume up/down events that originated from remapped function keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set the EF_FUNCTION_KEY flag in EventFlagsFromNative Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/x/events_x.cc

diff --git a/ui/events/x/events_x.cc b/ui/events/x/events_x.cc

index 1e5d81c2af3512742a93a035a7255cf83a207d7e..9d6b15a2eca3a0dc71a833999707b1385c79e011 100644

--- a/ui/events/x/events_x.cc

+++ b/ui/events/x/events_x.cc

@@ -174,6 +174,8 @@ int GetEventFlagsFromXKeyEvent(XEvent* xevent) {

return GetEventFlagsFromXState(xevent->xkey.state) |

(IsKeypadKey(XLookupKeysym(&xevent->xkey, 0)) ? ui::EF_NUMPAD_KEY : 0) |

+ (IsFunctionKey(XLookupKeysym(&xevent->xkey, 0)) ?

+ ui::EF_FUNCTION_KEY : 0) |

ime_fabricated_flag;

}

« no previous file with comments | « ui/events/event_constants.h ('k') | ui/events/x/events_x_unittest.cc » ('j') | ui/events/x/events_x_unittest.cc » ('J')