Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: ash/wm/maximize_mode/maximize_mode_event_blocker.cc

Issue 286103004: Blocked volume up/down events that originated from remapped function keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated EventsXTest.FunctionKeyEvents to be more explicit. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/maximize_mode/maximize_mode_event_blocker.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_event_blocker.cc b/ash/wm/maximize_mode/maximize_mode_event_blocker.cc
index 572886c1e0f8db6e10a02d9b8ddbc934e1518c08..24b1d7d8d4891330b9ef6d349a77e8ca6d0227ea 100644
--- a/ash/wm/maximize_mode/maximize_mode_event_blocker.cc
+++ b/ash/wm/maximize_mode/maximize_mode_event_blocker.cc
@@ -105,15 +105,15 @@ ui::EventTarget* BlockKeyboardAndTouchpadTargeter::FindTargetForEvent(
// when we begin using XI2 events for keyboard events
// (http://crbug.com/368750) and can tell which device the event is
// coming from, http://crbug.com/362881.
- // TODO(bruthig): Fix this to block rewritten volume keys
- // (i.e. F9 and F10) from the device's keyboard. https://crbug.com/368669
ui::KeyEvent* key_event = static_cast<ui::KeyEvent*>(event);
- if (key_event->key_code() != ui::VKEY_VOLUME_DOWN &&
- key_event->key_code() != ui::VKEY_VOLUME_UP
+ if ((key_event->flags() & ui::EF_FUNCTION_KEY) ||
+ (key_event->key_code() != ui::VKEY_VOLUME_DOWN &&
+ key_event->key_code() != ui::VKEY_VOLUME_UP
#if defined(OS_CHROMEOS)
- && key_event->key_code() != ui::VKEY_POWER
+ && key_event->key_code() != ui::VKEY_POWER
#endif
- ) {
+ )
+ ) {
return NULL;
}
}

Powered by Google App Engine
This is Rietveld 408576698