Issue 286103003: Remove include of Xlib.h in x11_atom_cache.h for the sake of tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286103003: Remove include of Xlib.h in x11_atom_cache.h for the sake of tests (Closed)

Created:
6 years, 7 months ago by pkotwicz

Modified:
6 years, 7 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove include of Xlib.h in x11_atom_cache.h and forward declare the necessary X11 types. This is needed for tests because the definition of None in X.h conflicts with the definition of None in gtest-type-util.h BUG=None TEST=None TBR=sadrul Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270790

Patch Set 1 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
	M	ui/gfx/x/x11_atom_cache.h	View		2 chunks	+8 lines, -10 lines	0 comments	Download
	M	ui/gfx/x/x11_atom_cache.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/286103003/20001

6 years, 7 months ago (2014-05-15 16:59:35 UTC) #4

Message was sent while issue was closed.

Change committed as 270790

Expand Messages | Collapse Messages