Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2861023002: Remove the Kernel setup_builtin_library transformation (Closed)

Created:
3 years, 7 months ago by Kevin Millikin (Google)
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the Kernel setup_builtin_library transformation This transformation replaces the body of _getMainClosure in dart:_builtin with `return main` for the script's main if there is one and removes the body if there is no main. Without this transformation fasta will compile `return null` and dartk will compile `return throw new NoSuchMethodError...`. Both of these patterns will be patched in the VM when dart:_builtin is compiled from Kernel. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/04f7ba272a65a3ea0e170b53c68e200deda959db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 2 chunks +1 line, -8 lines 0 comments Download
M pkg/kernel/lib/target/vm.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
The link-time transformation is still used by dartk for the Flutter target. I'll figure out ...
3 years, 7 months ago (2017-05-04 18:28:07 UTC) #2
Siggi Cherem (dart-lang)
lgtm, yay!
3 years, 7 months ago (2017-05-04 18:28:56 UTC) #3
Kevin Millikin (Google)
3 years, 7 months ago (2017-05-04 18:29:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04f7ba272a65a3ea0e170b53c68e200deda959db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698