Issue 2861007: AppCache: add plumbing to deliver logging messages to renderer process. These...

Issue 2861007: AppCache: add plumbing to deliver logging messages to renderer process. These... (Closed)

Created:
10 years, 6 months ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
Kavita Kanetkar

CC:
chromium-reviews, jam+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

AppCache: add plumbing to deliver logging messages to the renderer process. These messages will be plumbed thru to the console output for the page associated with 'host_id'.BUG=13685 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50197

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -1 line)			Patch
M	chrome/browser/appcache/appcache_frontend_proxy.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/appcache/appcache_frontend_proxy.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/common/appcache/appcache_dispatcher.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/appcache/appcache_dispatcher.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_frontend_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_frontend_impl.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_group_unittest.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_host_unittest.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_interfaces.h	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	webkit/appcache/appcache_request_handler_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/appcache/appcache_update_job_unittest.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/appcache/web_application_cache_host_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/appcache/web_application_cache_host_impl.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/simple_appcache_system.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kavita Kanetkar

LGTM! On 2010/06/17 22:36:10, michaeln wrote: > Please take a look

10 years, 6 months ago (2010-06-17 22:52:01 UTC) #2

Kavita Kanetkar

LGTM! http://codereview.chromium.org/2861007/diff/15002/23001 File chrome/browser/appcache/appcache_frontend_proxy.cc (right): http://codereview.chromium.org/2861007/diff/15002/23001#newcode35 chrome/browser/appcache/appcache_frontend_proxy.cc:35: sender_->Send(new AppCacheMsg_LogMessage( Doesn't fit on same line? http://codereview.chromium.org/2861007/diff/15002/23005 ...

10 years, 6 months ago (2010-06-17 22:52:13 UTC) #3

michaeln

10 years, 6 months ago (2010-06-17 23:24:11 UTC) #4

> AppCacheMsg_LogMessage(
> Doesn't fit on same line?

Yes it does, thank you.

Expand Messages | Collapse Messages