Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: third_party/WebKit/Source/core/dom/ModuleMap.h

Issue 2860993002: [ES6 modules] ModuleMap::GetFetchedModuleScript to return nullptr when entry not found / "fetching" (Closed)
Patch Set: update Modulator.h comment too Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Modulator.h ('k') | third_party/WebKit/Source/core/dom/ModuleMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ModuleMap.h
diff --git a/third_party/WebKit/Source/core/dom/ModuleMap.h b/third_party/WebKit/Source/core/dom/ModuleMap.h
index dcf51d17c8d02732e3add1c941c033da713bd27e..a7e10bef7431e4b25aa9be955157be37af18c7a4 100644
--- a/third_party/WebKit/Source/core/dom/ModuleMap.h
+++ b/third_party/WebKit/Source/core/dom/ModuleMap.h
@@ -41,8 +41,8 @@ class CORE_EXPORT ModuleMap final : public GarbageCollected<ModuleMap>,
SingleModuleClient*);
// Synchronously get the ModuleScript for a given URL.
- // Note: fetchSingleModuleScript of the ModuleScript must be complete before
- // calling this.
+ // If the URL wasn't fetched, or is currently being fetched, this returns a
+ // nullptr.
ModuleScript* GetFetchedModuleScript(const KURL&) const;
Modulator* GetModulator() { return modulator_; }
« no previous file with comments | « third_party/WebKit/Source/core/dom/Modulator.h ('k') | third_party/WebKit/Source/core/dom/ModuleMap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698