Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: components/policy/core/common/policy_load_status.cc

Issue 2860973002: Allow PolicyLoadStatusSample to override reporting method (Closed)
Patch Set: Cleanups and class rename. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/policy_load_status.cc
diff --git a/components/policy/core/common/policy_load_status.cc b/components/policy/core/common/policy_load_status.cc
index 71c5059a7fd338f7897d0a4bf318e10b2337903a..1495d7c545efb481cced190743cdbb7273acf0e9 100644
--- a/components/policy/core/common/policy_load_status.cc
+++ b/components/policy/core/common/policy_load_status.cc
@@ -4,6 +4,7 @@
#include "components/policy/core/common/policy_load_status.h"
+#include "base/bind.h"
#include "base/metrics/histogram.h"
#include "base/strings/stringprintf.h"
#include "components/policy/core/common/policy_types.h"
@@ -16,23 +17,27 @@ const char kHistogramName[] = "Enterprise.PolicyLoadStatus";
} // namespace
-PolicyLoadStatusSample::PolicyLoadStatusSample()
- : histogram_(base::LinearHistogram::FactoryGet(
- kHistogramName, 1, POLICY_LOAD_STATUS_SIZE,
- POLICY_LOAD_STATUS_SIZE + 1,
- base::Histogram::kUmaTargetedHistogramFlag)) {
+PolicyLoadStatusSampler::PolicyLoadStatusSampler() {
Add(POLICY_LOAD_STATUS_STARTED);
}
-PolicyLoadStatusSample::~PolicyLoadStatusSample() {
- for (int i = 0; i < POLICY_LOAD_STATUS_SIZE; ++i) {
- if (status_bits_[i])
- histogram_->Add(i);
- }
-}
+PolicyLoadStatusSampler::~PolicyLoadStatusSampler() {}
-void PolicyLoadStatusSample::Add(PolicyLoadStatus status) {
+void PolicyLoadStatusSampler::Add(PolicyLoadStatus status) {
status_bits_[status] = true;
}
+PolicyLoadStatusUmaReporter::PolicyLoadStatusUmaReporter() {}
+
+PolicyLoadStatusUmaReporter::~PolicyLoadStatusUmaReporter() {
+ base::HistogramBase* histogram(base::LinearHistogram::FactoryGet(
+ kHistogramName, 1, POLICY_LOAD_STATUS_SIZE, POLICY_LOAD_STATUS_SIZE + 1,
+ base::Histogram::kUmaTargetedHistogramFlag));
+
+ for (int i = 0; i < POLICY_LOAD_STATUS_SIZE; ++i) {
+ if (GetStatusSet()[i])
+ histogram->Add(i);
+ }
+}
+
} // namespace policy
« no previous file with comments | « components/policy/core/common/policy_load_status.h ('k') | components/policy/core/common/policy_loader_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698