Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: pkg/dev_compiler/lib/src/compiler/module_builder.dart

Issue 2860943003: update dependencies to use url style paths (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/module_builder.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/module_builder.dart b/pkg/dev_compiler/lib/src/compiler/module_builder.dart
index 6f6c237eac3ed9e76ca988fc95046b1545aeb419..3540b0b2ebb0ad81c3328a5a3fb375e496e4211f 100644
--- a/pkg/dev_compiler/lib/src/compiler/module_builder.dart
+++ b/pkg/dev_compiler/lib/src/compiler/module_builder.dart
@@ -274,7 +274,8 @@ class AmdModuleBuilder extends _ModuleBuilder {
var moduleVar =
new TemporaryId(pathToJSIdentifier(import.from.valueWithoutQuotes));
fnParams.add(moduleVar);
- dependencies.add(import.from);
+ dependencies.add(new LiteralString(
+ '"${path.url.joinAll(path.split(import.from.valueWithoutQuotes))}"'));
Jennifer Messerly 2017/05/04 18:20:26 we chatted about moving this fix to code_generator
// TODO(jmesserly): optimize for the common case of a single import.
for (var importName in import.namedImports) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698