Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2860943003: update dependencies to use url style paths (Closed)

Created:
3 years, 7 months ago by jakemac
Modified:
3 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, vsm
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make it more general #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/dev_compiler/lib/src/compiler/command.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jakemac
This gets things happy on windows (with amd at least). I don't know if it ...
3 years, 7 months ago (2017-05-04 17:34:31 UTC) #2
Jennifer Messerly
lgtm with change we discussed. thanks for tracking this down! https://codereview.chromium.org/2860943003/diff/1/pkg/dev_compiler/lib/src/compiler/module_builder.dart File pkg/dev_compiler/lib/src/compiler/module_builder.dart (right): https://codereview.chromium.org/2860943003/diff/1/pkg/dev_compiler/lib/src/compiler/module_builder.dart#newcode278 ...
3 years, 7 months ago (2017-05-04 18:20:26 UTC) #3
jakemac
On 2017/05/04 18:20:26, Jennifer Messerly wrote: > lgtm with change we discussed. thanks for tracking ...
3 years, 7 months ago (2017-05-04 19:43:48 UTC) #4
jakemac
3 years, 7 months ago (2017-05-04 19:45:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fc0c45c7909c661c47a410fbb6e9eb3ee7013461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698