Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 286093003: Remove disable-enterprise-user-reporting flag. (Closed)

Created:
6 years, 7 months ago by Steve Condie
Modified:
6 years, 7 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove disable-enterprise-user-reporting flag. BUG=350242 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271460

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unneeded includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 3 chunks +1 line, -4 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Steve Condie
6 years, 7 months ago (2014-05-16 22:55:44 UTC) #1
Joao da Silva
lgtm https://codereview.chromium.org/286093003/diff/1/chrome/browser/chromeos/policy/device_status_collector.cc File chrome/browser/chromeos/policy/device_status_collector.cc (right): https://codereview.chromium.org/286093003/diff/1/chrome/browser/chromeos/policy/device_status_collector.cc#newcode11 chrome/browser/chromeos/policy/device_status_collector.cc:11: #include "base/command_line.h" Remove https://codereview.chromium.org/286093003/diff/1/chrome/browser/chromeos/policy/device_status_collector.cc#newcode27 chrome/browser/chromeos/policy/device_status_collector.cc:27: #include "chromeos/chromeos_switches.h" Remove
6 years, 7 months ago (2014-05-19 12:49:50 UTC) #2
Steve Condie
https://codereview.chromium.org/286093003/diff/1/chrome/browser/chromeos/policy/device_status_collector.cc File chrome/browser/chromeos/policy/device_status_collector.cc (right): https://codereview.chromium.org/286093003/diff/1/chrome/browser/chromeos/policy/device_status_collector.cc#newcode11 chrome/browser/chromeos/policy/device_status_collector.cc:11: #include "base/command_line.h" On 2014/05/19 12:49:50, Joao da Silva wrote: ...
6 years, 7 months ago (2014-05-19 17:44:51 UTC) #3
Steve Condie
The CQ bit was checked by stepco@chromium.org
6 years, 7 months ago (2014-05-19 17:45:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/286093003/20001
6 years, 7 months ago (2014-05-19 17:46:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 19:48:21 UTC) #6
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 7 months ago (2014-05-19 19:48:21 UTC) #7
Steve Condie
The CQ bit was checked by stepco@chromium.org
6 years, 7 months ago (2014-05-19 20:03:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/286093003/20001
6 years, 7 months ago (2014-05-19 20:04:03 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 20:05:22 UTC) #10
Message was sent while issue was closed. 
Change committed as 271460

Powered by Google App Engine
This is Rietveld 408576698