Issue 2860893003: Revert "Make JavaScriptBackend.processAnnotations element-model agnostic"

Issue 2860893003: Revert "Make JavaScriptBackend.processAnnotations element-model agnostic" (Closed)

Created:
3 years, 7 months ago by sra1

Modified:
3 years, 7 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Make JavaScriptBackend.processAnnotations element-model agnostic" This reverts commit 859bb784eda9ab35b0ce9004adb5d5117544b288. The change caused a 2% code size regression on some large angular apps. TBR=johnniwinther@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/457c277f6f0aa719b7be94cbe6fedf7a749b56e0

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -103 lines)			Patch
M	pkg/compiler/lib/src/common_elements.dart	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/inferrer_engine.dart	View	2 chunks	+1 line, -12 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/type_graph_nodes.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/annotations.dart	View	2 chunks	+25 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	4 chunks	+17 lines, -27 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map.dart	View	3 chunks	+2 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/resolution_strategy.dart	View	2 chunks	+1 line, -17 lines	0 comments	Download
M	tests/compiler/dart2js/expect_annotations_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (1 generated)

sra1

Committed patchset #1 (id:1) manually as 457c277f6f0aa719b7be94cbe6fedf7a749b56e0 (presubmit successful).

3 years, 7 months ago (2017-05-04 03:03:26 UTC) #2

Message was sent while issue was closed.

lgtm