Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1834)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js

Issue 2860883004: [CUPS] Fix the issue the default queue value not being persisted with each new printer setup. (Closed)
Patch Set: Address michaelpg@'s comment. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
index d97e93bd526bea01795afe316b1875f942fcf82c..d2270f7c1a2fe01b487d5cc35d01b936cc3ae8d7 100644
--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
@@ -135,7 +135,7 @@ Polymer({
printerName: '',
printerPPDPath: '',
printerProtocol: 'ipp',
- printerQueue: 'ipp/print',
+ printerQueue: '',
printerStatus: '',
};
},
@@ -155,6 +155,10 @@ Polymer({
/** @private */
switchToManufacturerDialog_: function() {
+ // Set the default printer queue to be "ipp/print".
+ if (!this.newPrinter.printerQueue)
+ this.set('newPrinter.printerQueue', 'ipp/print');
+
this.$$('add-printer-dialog').close();
this.fire('open-manufacturer-model-dialog');
},
@@ -171,7 +175,7 @@ Polymer({
* @private
*/
onProtocolChange_: function(event) {
- this.newPrinter.printerProtocol = event.target.value;
+ this.set('newPrinter.printerProtocol', event.target.value);
},
});
@@ -236,7 +240,7 @@ Polymer({
* @private
*/
printerPPDPathChanged_: function(path) {
- this.newPrinter.printerPPDPath = path;
+ this.set('newPrinter.printerPPDPath', path);
this.$$('paper-input').value = this.getBaseName_(path);
},
« no previous file with comments | « chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698