Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ui/views/controls/menu/menu_item_view.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)
Patch Set: Revert comment. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/menu/menu_item_view.cc
diff --git a/ui/views/controls/menu/menu_item_view.cc b/ui/views/controls/menu/menu_item_view.cc
index 46ff17be1aec4f3ee0310ea9324da10cf58785c4..63f7676b1fd2c2d52acf3589abac2ae658cbadf4 100644
--- a/ui/views/controls/menu/menu_item_view.cc
+++ b/ui/views/controls/menu/menu_item_view.cc
@@ -162,6 +162,7 @@ void MenuItemView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
// |title_|.
View* child = child_at(0);
ui::AXNodeData node_data;
+ node_data.ClearBitfields();
child->GetAccessibleNodeData(&node_data);
item_text = node_data.GetString16Attribute(ui::AX_ATTR_NAME);
} else {
@@ -171,7 +172,7 @@ void MenuItemView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
switch (GetType()) {
case SUBMENU:
- node_data->AddStateFlag(ui::AX_STATE_HASPOPUP);
+ node_data->AddState(ui::AX_STATE_HASPOPUP);
break;
case CHECKBOX:
case RADIO: {

Powered by Google App Engine
This is Rietveld 408576698