content/browser/accessibility/browser_accessibility_manager_android.cc - Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)

Patch Set: Revert comment. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility.cc ('k') | content/browser/accessibility/browser_accessibility_manager_auralinux.cc » ('j') | content/browser/accessibility/browser_accessibility_manager_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc

index 5923de3fd8cabb45c3cea5d0338ed22e4ab88de1..4da2121fc81b05828827b8ed38c0c727724590f5 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc

@@ -189,9 +189,10 @@ BrowserAccessibilityManagerAndroid::~BrowserAccessibilityManagerAndroid() {

ui::AXTreeUpdate

BrowserAccessibilityManagerAndroid::GetEmptyDocument() {

ui::AXNodeData empty_document;

+ empty_document.ClearBitfields();

empty_document.id = 0;

empty_document.role = ui::AX_ROLE_ROOT_WEB_AREA;

- empty_document.state = 1 << ui::AX_STATE_READ_ONLY;

+ empty_document.AddState(ui::AX_STATE_READ_ONLY);

ui::AXTreeUpdate update;

update.root_id = empty_document.id;

@@ -989,11 +990,12 @@ void BrowserAccessibilityManagerAndroid::OnAutofillPopupDisplayed(

g_autofill_popup_proxy_node = BrowserAccessibility::Create();

g_autofill_popup_proxy_node_ax_node = new ui::AXNode(nullptr, -1, -1);

ui::AXNodeData ax_node_data;

+ ax_node_data.ClearBitfields();

ax_node_data.role = ui::AX_ROLE_MENU;

ax_node_data.SetName("Autofill");

- ax_node_data.state = 1 << ui::AX_STATE_READ_ONLY;

- ax_node_data.state |= 1 << ui::AX_STATE_FOCUSABLE;

- ax_node_data.state |= 1 << ui::AX_STATE_SELECTABLE;

+ ax_node_data.AddState(ui::AX_STATE_READ_ONLY);

+ ax_node_data.AddState(ui::AX_STATE_FOCUSABLE);

+ ax_node_data.AddState(ui::AX_STATE_SELECTABLE);

g_autofill_popup_proxy_node_ax_node->SetData(ax_node_data);

g_autofill_popup_proxy_node->Init(this, g_autofill_popup_proxy_node_ax_node);