ui/views/accessibility/ax_window_obj_wrapper.cc - Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/ax_window_obj_wrapper.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)

Patch Set: Delete AXNodeData::Init() and clear bitfields in AXNodeData() instead. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/accessibility/ax_window_obj_wrapper.cc

diff --git a/ui/views/accessibility/ax_window_obj_wrapper.cc b/ui/views/accessibility/ax_window_obj_wrapper.cc

index 0f08a3c8434892d11c5071a577d14714744b795b..e0af88d41f22b16f5a6b705629651f74d22f81a1 100644

--- a/ui/views/accessibility/ax_window_obj_wrapper.cc

+++ b/ui/views/accessibility/ax_window_obj_wrapper.cc

@@ -53,7 +53,6 @@ void AXWindowObjWrapper::Serialize(ui::AXNodeData* out_node_data) {

out_node_data->role = is_alert_ ? ui::AX_ROLE_ALERT : ui::AX_ROLE_WINDOW;

out_node_data->AddStringAttribute(ui::AX_ATTR_NAME,

base::UTF16ToUTF8(window_->GetTitle()));

- out_node_data->state = 0;

out_node_data->location = gfx::RectF(window_->GetBoundsInScreen());

ui::AXTreeIDRegistry::AXTreeID child_ax_tree_id =