content/renderer/accessibility/blink_ax_tree_source.cc - Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)

Patch Set: Delete AXNodeData::Init() and clear bitfields in AXNodeData() instead. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index 397c86e42ad0ce14085125a9a9e722163783a016..e70dc2027adfc4774dc814cfcbbc16d458f44d11 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -629,7 +629,7 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

dst->AddBoolAttribute(ui::AX_ATTR_LIVE_ATOMIC, src.LiveRegionAtomic());

dst->AddBoolAttribute(ui::AX_ATTR_LIVE_BUSY, src.LiveRegionBusy());

if (src.LiveRegionBusy())

- dst->state |= (1 << ui::AX_STATE_BUSY);

+ dst->AddState(ui::AX_STATE_BUSY);

if (!src.LiveRegionStatus().IsEmpty()) {

dst->AddStringAttribute(ui::AX_ATTR_LIVE_STATUS,

src.LiveRegionStatus().Utf8());