Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.mm

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)
Patch Set: Delete AXNodeData::Init() and clear bitfields in AXNodeData() instead. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager_mac.mm
diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm
index b3c484e74f76fd822316cb7657ce62d8876bdcab..8e70dd3872c3aa59de1da0b266d8d4beb32efdb5 100644
--- a/content/browser/accessibility/browser_accessibility_manager_mac.mm
+++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm
@@ -135,8 +135,7 @@ ui::AXTreeUpdate
ui::AXNodeData empty_document;
empty_document.id = 0;
empty_document.role = ui::AX_ROLE_ROOT_WEB_AREA;
- empty_document.state =
- 1 << ui::AX_STATE_READ_ONLY;
+ empty_document.AddState(ui::AX_STATE_READ_ONLY);
ui::AXTreeUpdate update;
update.root_id = empty_document.id;
update.nodes.push_back(empty_document);
@@ -371,7 +370,7 @@ void BrowserAccessibilityManagerMac::OnNodeDataWillChange(
role == ui::AX_ROLE_TEXT_FIELD) {
old_text = old_node_data.GetString16Attribute(ui::AX_ATTR_VALUE);
new_text = new_node_data.GetString16Attribute(ui::AX_ATTR_VALUE);
- } else if (new_node_data.state & (1 << ui::AX_STATE_EDITABLE)) {
+ } else if (new_node_data.HasState(ui::AX_STATE_EDITABLE)) {
old_text = old_node_data.GetString16Attribute(ui::AX_ATTR_NAME);
new_text = new_node_data.GetString16Attribute(ui::AX_ATTR_NAME);
}

Powered by Google App Engine
This is Rietveld 408576698