ui/views/bubble/bubble_dialog_delegate.cc - Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_dialog_delegate.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)

Patch Set: Review comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_dialog_delegate.cc

diff --git a/ui/views/bubble/bubble_dialog_delegate.cc b/ui/views/bubble/bubble_dialog_delegate.cc

index 0f239090451351e9ed2b1b2358027eb24c4f6342..313ea2ddfb8a8f50e569dba42c52a095d608f329 100644

--- a/ui/views/bubble/bubble_dialog_delegate.cc

+++ b/ui/views/bubble/bubble_dialog_delegate.cc

@@ -320,6 +320,7 @@ void BubbleDialogDelegateView::HandleVisibilityChanged(Widget* widget,

// http://crbug.com/474622 for details.

if (widget == GetWidget() && visible) {

ui::AXNodeData node_data;

+ node_data.Init();

GetAccessibleNodeData(&node_data);

if (node_data.role == ui::AX_ROLE_ALERT_DIALOG)

NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);