A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

ui/accessibility/platform/ax_platform_node_auralinux.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/accessibility/platform/ax_platform_node_auralinux.h"
 
 #include <stdint.h>
 
 #include "base/command_line.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 443 matching lines @@
       return ATK_ROLE_SECTION;
 #endif
     case ui::AX_ROLE_WINDOW:
       return ATK_ROLE_WINDOW;
     default:
       return ATK_ROLE_UNKNOWN;
   }
 }
 
 void AXPlatformNodeAuraLinux::GetAtkState(AtkStateSet* atk_state_set) {
-  const uint32_t state = GetData().state;
-
-  if (state & (1 << ui::AX_STATE_DEFAULT))
+  if (GetData().HasState(ui::AX_STATE_DEFAULT))

[tapted, 2017/05/05 05:53:36]

Cache GetData() to a local var?

[Patti Lor, 2017/05/08 00:28:08]

Done.

     atk_state_set_add_state(atk_state_set, ATK_STATE_DEFAULT);
-  if (state & (1 << ui::AX_STATE_EDITABLE))
+  if (GetData().HasState(ui::AX_STATE_EDITABLE))
     atk_state_set_add_state(atk_state_set, ATK_STATE_EDITABLE);
-  if (!(state & (1 << ui::AX_STATE_DISABLED)))
+  if (!GetData().HasState(ui::AX_STATE_DISABLED))
     atk_state_set_add_state(atk_state_set, ATK_STATE_ENABLED);
-  if (state & (1 << ui::AX_STATE_EXPANDED))
+  if (GetData().HasState(ui::AX_STATE_EXPANDED))
     atk_state_set_add_state(atk_state_set, ATK_STATE_EXPANDED);
-  if (state & (1 << ui::AX_STATE_FOCUSABLE))
+  if (GetData().HasState(ui::AX_STATE_FOCUSABLE))
     atk_state_set_add_state(atk_state_set, ATK_STATE_FOCUSABLE);
-  if (state & (1 << ui::AX_STATE_PRESSED))
+  if (GetData().HasState(ui::AX_STATE_PRESSED))
     atk_state_set_add_state(atk_state_set, ATK_STATE_PRESSED);
-  if (state & (1 << ui::AX_STATE_SELECTABLE))
+  if (GetData().HasState(ui::AX_STATE_SELECTABLE))
     atk_state_set_add_state(atk_state_set, ATK_STATE_SELECTABLE);
-  if (state & (1 << ui::AX_STATE_SELECTED))
+  if (GetData().HasState(ui::AX_STATE_SELECTED))
     atk_state_set_add_state(atk_state_set, ATK_STATE_SELECTED);
 
   // Checked state
   const auto checked_state = static_cast<ui::AXCheckedState>(
       GetIntAttribute(ui::AX_ATTR_CHECKED_STATE));
   switch (checked_state) {
     case ui::AX_CHECKED_STATE_MIXED:
       atk_state_set_add_state(atk_state_set, ATK_STATE_INDETERMINATE);
       break;
     case ui::AX_CHECKED_STATE_TRUE:
@@ skipping 77 matching lines @@
 
 void AXPlatformNodeAuraLinux::GetSize(gint* width, gint* height) {
   gfx::Rect rect_size = gfx::ToEnclosingRect(GetData().location);
   if (width)
     *width = rect_size.width();
   if (height)
     *height = rect_size.height();
 }
 
 }  // namespace ui