A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

ui/accessibility/ax_tree.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/accessibility/ax_tree.h"
 
 #include <stddef.h>
 
 #include <set>
 
@@ skipping 110 matching lines @@
 AXTreeDelegate::AXTreeDelegate() {
 }
 
 AXTreeDelegate::~AXTreeDelegate() {
 }
 
 AXTree::AXTree()
     : delegate_(NULL), root_(NULL) {
   AXNodeData root;
   root.id = -1;
+  root.ClearBitfields();
 
   AXTreeUpdate initial_state;
   initial_state.root_id = -1;
   initial_state.nodes.push_back(root);
   CHECK(Unserialize(initial_state)) << error();
 }
 
 AXTree::AXTree(const AXTreeUpdate& initial_state)
     : delegate_(NULL), root_(NULL) {
   CHECK(Unserialize(initial_state)) << error();
@@ skipping 212 matching lines @@
 
   const AXNodeData& old_data = node->data();
   delegate_->OnNodeDataWillChange(this, old_data, new_data);
 
   if (old_data.role != new_data.role)
     delegate_->OnRoleChanged(this, node, old_data.role, new_data.role);
 
   if (old_data.state != new_data.state) {
     for (int i = AX_STATE_NONE + 1; i <= AX_STATE_LAST; ++i) {
       AXState state = static_cast<AXState>(i);
-      if (old_data.HasStateFlag(state) != new_data.HasStateFlag(state)) {
-        delegate_->OnStateChanged(this, node, state,
-                                  new_data.HasStateFlag(state));
-      }
+      if (old_data.HasState(state) != new_data.HasState(state))
+        delegate_->OnStateChanged(this, node, state, new_data.HasState(state));
     }
   }
 
   auto string_callback = [this, node](AXStringAttribute attr,
                                       const std::string& old_string,
                                       const std::string& new_string) {
     delegate_->OnStringAttributeChanged(this, node, attr, old_string,
                                         new_string);
   };
   CallIfAttributeValuesChanged(old_data.string_attributes,
@@ skipping 118 matching lines @@
       update_state->pending_nodes.insert(child);
       update_state->new_nodes.insert(child);
     }
     new_children->push_back(child);
   }
 
   return success;
 }
 
 }  // namespace ui