Issue 2860883002: Rename InstructionsReader to ImageReader for symmetry with ImageWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2860883002: Rename InstructionsReader to ImageReader for symmetry with ImageWriter. (Closed)

Created:
3 years, 7 months ago by rmacnak

Modified:
3 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -14 lines)			Patch
M	runtime/vm/clustered_snapshot.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/clustered_snapshot.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 7 months ago (2017-05-04 16:59:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
02c54a6aa62c56890b51b06d7f7642e8e1e46b80 (presubmit successful).