Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: components/browser_watcher/stability_paths.h

Issue 2860863003: Rework GetStabilityFileForProcess for use by Crashpad integration (Closed)
Patch Set: Merge Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/stability_paths.h
diff --git a/components/browser_watcher/stability_paths.h b/components/browser_watcher/stability_paths.h
index d66718c6226d478c951fa38f6e65c96464a8a3ff..61824cda772406aaa3efa467a672d1f5885dfc12 100644
--- a/components/browser_watcher/stability_paths.h
+++ b/components/browser_watcher/stability_paths.h
@@ -7,16 +7,27 @@
#include "base/files/file_path.h"
#include "base/process/process.h"
+#include "build/build_config.h"
+
+#if defined(OS_WIN)
+#include <winsock2.h>
+#endif // defined(OS_WIN)
namespace browser_watcher {
#if defined(OS_WIN)
-// Returns the the stability debugging directory.
+// Returns the stability debugging directory.
base::FilePath GetStabilityDir(const base::FilePath& user_data_dir);
-// On success, |path| contains the path to the stability debugging information
-// file for |process|.
+// Returns the stability debugging path, which is based on pid and creation time
+// to ensure unicity in the face of pid recycling.
Mark Mentovai 2017/05/04 21:27:37 uniqueness > uniquity > unicity, although they’re
manzagop (departed) 2017/05/05 14:35:22 Done.
+base::FilePath GetStabilityFileForProcess(base::ProcessId pid,
+ timeval creation_time,
+ const base::FilePath& user_data_dir);
+
+// On success, returns true and |path| contains the path to the stability file.
+// On failure, returns false.
bool GetStabilityFileForProcess(const base::Process& process,
const base::FilePath& user_data_dir,
base::FilePath* path);

Powered by Google App Engine
This is Rietveld 408576698