Rework GetStabilityFileForProcess for use by Crashpad integration

components/browser_watcher/BUILD.gn

Index: components/browser_watcher/BUILD.gn
diff --git a/components/browser_watcher/BUILD.gn b/components/browser_watcher/BUILD.gn
index 380a17521cd952364464eb973317aaea2f76ae00..1db2f3fd02dc45e4b924154f889dd500fe35bdf8 100644
--- a/components/browser_watcher/BUILD.gn
+++ b/components/browser_watcher/BUILD.gn
@@ -94,6 +94,8 @@ static_library("stability_client") {
   ]
   deps = [
     "//base",
+    "//third_party/crashpad/crashpad/compat",

[Mark Mentovai, 2017/05/04 16:47:10]

Did you really need this? crashpad/util didn’t give you what you needed?

[manzagop (departed), 2017/05/04 19:52:41]

Yup, otherwise I get "C1083: Cannot open include file: 'sys/time.h'".

I notice I can remove it if I switch compat/BUILD.gn from using public_configs
to using all_dependent_configs.

[Mark Mentovai, 2017/05/04 21:27:37]

That’s never really the right solution (which is probably why you didn’t do it!)

What about making compat a public_dep of util instead of a dep?

[manzagop (departed), 2017/05/05 14:35:22]

Ah nice! Removed here, below and in components/crash/content/app:unit_tests.

Done.

+    "//third_party/crashpad/crashpad/util",
   ]
 }