Rework GetStabilityFileForProcess for use by Crashpad integration

components/browser_watcher/stability_paths.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_BROWSER_WATCHER_STABILITY_PATHS_H_
 #define COMPONENTS_BROWSER_WATCHER_STABILITY_PATHS_H_
 
 #include "base/files/file_path.h"
 #include "base/process/process.h"
 
+#if defined(OS_WIN)

[Mark Mentovai, 2017/05/04 16:47:10]

You should #include "build/build_config.h" to successfully use this macro.

[manzagop (departed), 2017/05/04 19:52:41]

Done.

+#include <winsock2.h>
+#endif  // defined(OS_WIN)
+
 namespace browser_watcher {
 
-#if defined(OS_WIN)

[Mark Mentovai, 2017/05/04 16:47:10]

You’re getting rid of these guards here in the header, but the implementation’s
still guarded as Windows-only. What’s up?

[manzagop (departed), 2017/05/04 19:52:41]

Yeah. The intent is for these to be cross-platform but I've only got windows
implementations for now. I'll put back the guards on the declarations.

-
-// Returns the the stability debugging directory.
+// Returns the stability debugging directory.
 base::FilePath GetStabilityDir(const base::FilePath& user_data_dir);
 
-// On success, |path| contains the path to the stability debugging information
-// file for |process|.
+// Returns the stability debugging path, which is based on pid and creation time
+// to ensure unicity in the face of pid recycling.
+base::FilePath GetStabilityFileForProcess(base::ProcessId pid,
+                                          timeval creation_time,
+                                          const base::FilePath& user_data_dir);
+
+// On success, returns true and |path| contains the path to the stability file.
+// On failure, returns false.
 bool GetStabilityFileForProcess(const base::Process& process,
                                 const base::FilePath& user_data_dir,
                                 base::FilePath* path);
 
 // Returns a pattern that matches file names returned by GetFileForProcess.
 base::FilePath::StringType GetStabilityFilePattern();
 
 // Marks the stability file for deletion.
 void MarkStabilityFileForDeletion(const base::FilePath& user_data_dir);
 
-#endif  // defined(OS_WIN)
-
 }  // namespace browser_watcher
 
 #endif  // COMPONENTS_BROWSER_WATCHER_STABILITY_PATHS_H_