Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2860823002: Introduce classes for string and name indexes (Closed)

Created:
3 years, 7 months ago by Kevin Millikin (Google)
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce classes for string and name indexes In the VM's Kernel representation, introduce wrapper classes for string and name indexes so it is obvious which one is which. For convenience there is an implicit conversion so that they can each be used where an int is allowed. However, there is no implicit conversion _to_ either of these types. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/9935e86688a9624bbcb1e7b35c1e95af5c43c33e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -242 lines) Patch
M runtime/vm/bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap_nocore.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/kernel.h View 42 chunks +99 lines, -72 lines 0 comments Download
M runtime/vm/kernel_binary.h View 3 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 19 chunks +25 lines, -25 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 6 chunks +11 lines, -6 lines 0 comments Download
M runtime/vm/kernel_reader.h View 4 chunks +9 lines, -8 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 6 chunks +44 lines, -43 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 34 chunks +68 lines, -65 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
3 years, 7 months ago (2017-05-03 19:48:46 UTC) #2
Vyacheslav Egorov (Google)
this is very nice! thanks for doing this. lgtm
3 years, 7 months ago (2017-05-03 19:54:10 UTC) #3
Kevin Millikin (Google)
3 years, 7 months ago (2017-05-03 22:43:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9935e86688a9624bbcb1e7b35c1e95af5c43c33e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698