Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2860753005: Make elements/names.dart its own library (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -28 lines) Patch
M pkg/compiler/lib/src/common/names.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/names.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/operators.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/ir_element_map.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization_util.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/gvn_dynamic_field_get_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/jsinterop/world_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/lookup_member_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/members_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/needs_no_such_method_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/members_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-05 12:05:58 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-05 18:08:34 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-08 09:00:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ab688ab590fcbc389364638cd11b99fbb5ff6cff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698