Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 286073004: Fix builtin/runtime name clashes generated by macros (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix builtin/runtime name clashes generated by macros Specifically: DataView{S,G}et* and a few more Math functions. Also change indentation in typedarray.js for easier future builtins parsing. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -158 lines) Patch
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 3 chunks +7 lines, -7 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 5 chunks +148 lines, -148 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
More of the same. PTAL.
6 years, 7 months ago (2014-05-15 09:17:57 UTC) #1
Dmitry Lomov (no reviews)
lgtm
6 years, 7 months ago (2014-05-15 10:55:35 UTC) #2
Jakob Kummerow
6 years, 7 months ago (2014-05-15 13:03:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698