Network traffic annotation added to indexed_db.

content/browser/indexed_db/indexed_db_backing_store.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/files/file_path.h"
@@ skipping 21 matching lines @@
 #include "content/browser/indexed_db/indexed_db_value.h"
 #include "content/browser/indexed_db/leveldb/leveldb_comparator.h"
 #include "content/browser/indexed_db/leveldb/leveldb_database.h"
 #include "content/browser/indexed_db/leveldb/leveldb_factory.h"
 #include "content/browser/indexed_db/leveldb/leveldb_iterator.h"
 #include "content/browser/indexed_db/leveldb/leveldb_transaction.h"
 #include "content/common/indexed_db/indexed_db_key.h"
 #include "content/common/indexed_db/indexed_db_key_path.h"
 #include "content/common/indexed_db/indexed_db_key_range.h"
 #include "content/public/browser/browser_thread.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_request_context.h"
 #include "storage/browser/blob/blob_data_handle.h"
 #include "storage/browser/fileapi/file_stream_writer.h"
 #include "storage/browser/fileapi/file_writer_delegate.h"
 #include "storage/browser/fileapi/local_file_stream_writer.h"
 #include "storage/common/database/database_identifier.h"
 #include "storage/common/fileapi/file_system_mount_option.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBTypes.h"
 #include "third_party/leveldatabase/env_chromium.h"
 
@@ skipping 2497 matching lines @@
         storage::FileStreamWriter::CreateForLocalFile(
             task_runner_.get(), file_path, 0,
             storage::FileStreamWriter::CREATE_NEW_FILE));
     std::unique_ptr<FileWriterDelegate> delegate(
         base::MakeUnique<FileWriterDelegate>(
             std::move(writer), storage::FlushPolicy::FLUSH_ON_COMPLETION));
 
     DCHECK(blob_url.is_valid());
     net::URLRequestContext* request_context =
         request_context_getter->GetURLRequestContext();
+    net::NetworkTrafficAnnotationTag traffic_annotation =

[jsbell, 2017/05/03 15:51:56]

The request is for a content of a local file ("blob") resource. This will not
actually hit the network.

The code is copying data already held in Chrome - referenced by a blob URL -
into database storage.

[Ramin Halavati, 2017/05/04 04:41:01]

Thank you for clarification. As a presubmit checker will be added for all
network requests that are in codes which are compiled during building Chrome, we
need to annotate this as well. But we can choose destination as LOCAL and don't
need policy.

+        net::DefineNetworkTrafficAnnotation("...", R"(

[jsbell, 2017/05/04 15:53:16]

persist_blob_to_indexeddb

[Ramin Halavati, 2017/05/05 08:43:21]

Done.

+        semantics {
+          sender: "..."

[jsbell, 2017/05/04 15:53:16]

Indexed DB

[Ramin Halavati, 2017/05/05 08:43:22]

Done.

+          description: "..."

[jsbell, 2017/05/04 15:53:16]

A web page's script has created a Blob (or File) object (either directly via
constructors, or by using file upload to a form, or via a fetch()). The script
has then made a request to store data including the Blob via the Indexed DB API.
As part of committing the database transaction, the content of the Blob is being
copied into a file in the database's directory.

[Ramin Halavati, 2017/05/05 08:43:21]

Done.

+          trigger: "..."

[jsbell, 2017/05/04 15:53:16]

The script has then made a request to store data including a Blob via the
Indexed DB API.

[Ramin Halavati, 2017/05/05 08:43:21]

Done.

+          data: "..."

[jsbell, 2017/05/04 15:53:17]

A Blob or File object referenced by script, either created directly via
constructors, or by using file upload to a form, or drag/dop, or via a fetch()
or other APIs that produce Blobs.

[Ramin Halavati, 2017/05/05 08:43:21]

Done.

+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER/LOCAL

[jsbell, 2017/05/04 15:53:16]

LOCAL

[Ramin Halavati, 2017/05/05 08:43:21]

Done.

+        }
+        policy {
+          cookies_allowed: false/true

[Ramin Halavati, 2017/05/05 08:43:22]

Cookies are enabled by default, it seems that you are not using them, can I add
a CL that adds net::LOAD_DO_NOT_SAVE_COOKIES and                         
net::LOAD_DO_NOT_SEND_COOKIES load flags?

[jsbell, 2017/05/05 18:23:50]

Yes please!

[Ramin Halavati, 2017/05/08 09:51:04]

Done, in CL https://codereview.chromium.org/2864243002

+          cookies_store: "..."
+          setting: "..."
+          chrome_policy {
+            [POLICY_NAME] {
+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+              [POLICY_NAME]: ... //(value to disable it)
+            }
+          }
+          policy_exception_justification: "..."
+        })");
     std::unique_ptr<net::URLRequest> blob_request(
         request_context->CreateRequest(blob_url, net::DEFAULT_PRIORITY,
-                                       delegate.get()));
+                                       delegate.get(), traffic_annotation));
 
     this->file_path_ = file_path;
     this->last_modified_ = last_modified;
 
     delegate->Start(std::move(blob_request),
                     base::Bind(&LocalWriteClosure::Run, this));
     chained_blob_writer_->set_delegate(std::move(delegate));
   }
 
  private:
@@ skipping 1887 matching lines @@
 
 IndexedDBBackingStore::Transaction::WriteDescriptor::WriteDescriptor(
     const WriteDescriptor& other) = default;
 IndexedDBBackingStore::Transaction::WriteDescriptor::~WriteDescriptor() =
     default;
 IndexedDBBackingStore::Transaction::WriteDescriptor&
     IndexedDBBackingStore::Transaction::WriteDescriptor::
     operator=(const WriteDescriptor& other) = default;
 
 }  // namespace content