Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2860683002: WIP: Pref service: use the incognito support from Chrome

Created:
3 years, 7 months ago by tibell
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pref service: use the incognito support from Chrome BUG=654988

Patch Set 1 #

Patch Set 2 : Make compile on Chrome OS #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -95 lines) Patch
M chrome/browser/prefs/browser_prefs.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_util.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_util.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 6 chunks +27 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +29 lines, -4 lines 0 comments Download
M components/prefs/pref_value_store.h View 2 chunks +5 lines, -2 lines 0 comments Download
M components/prefs/pref_value_store.cc View 4 chunks +12 lines, -7 lines 0 comments Download
M components/sync_preferences/pref_service_syncable.h View 1 chunk +0 lines, -9 lines 0 comments Download
M components/sync_preferences/pref_service_syncable.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.h View 2 chunks +10 lines, -0 lines 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.cc View 3 chunks +89 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2856083002 Patch 40001

Messages

Total messages: 11 (11 generated)
tibell
Description was changed from ========== Pref service: use the incognito support from Chrome BUG=654988 ========== ...
3 years, 7 months ago (2017-05-03 05:34:37 UTC) #1
tibell
The CQ bit was checked by tibell@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 05:34:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860683002/1
3 years, 7 months ago (2017-05-03 05:35:03 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-03 05:42:36 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/426066)
3 years, 7 months ago (2017-05-03 05:42:36 UTC) #5
tibell
The CQ bit was checked by tibell@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 05:52:51 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860683002/10019
3 years, 7 months ago (2017-05-03 05:53:02 UTC) #7
tibell
The CQ bit was checked by tibell@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 05:56:16 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860683002/30001
3 years, 7 months ago (2017-05-03 05:56:20 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-03 06:04:20 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 06:04:20 UTC) #11 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698