Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chromecast/media/cma/backend/alsa/BUILD.gn

Issue 2860673003: [Chromecast] Correct libcast_governor behavior. (Closed)
Patch Set: Remove debug logging Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/backend/alsa/BUILD.gn
diff --git a/chromecast/media/cma/backend/alsa/BUILD.gn b/chromecast/media/cma/backend/alsa/BUILD.gn
index 6647d166ba2960ece89698b265431ffafadac5e7..66c3712c1bc68305e6add76f027fb266b6f60415 100644
--- a/chromecast/media/cma/backend/alsa/BUILD.gn
+++ b/chromecast/media/cma/backend/alsa/BUILD.gn
@@ -135,14 +135,34 @@ source_set("test_support") {
}
shared_library("libcast_governor_1.0") {
+ deps = [
+ ":governor",
+ ]
+}
+
+test("libcast_governor_unittests") {
sources = [
- "post_processors/governor_shlib.cc",
+ "post_processors/governor_unittest.cc",
]
+ deps = [
+ ":governor",
+ "//base",
+ "//base/test:run_all_unittests",
+ "//media",
+ "//testing/gtest",
+ ]
+}
+source_set("governor") {
+ sources = [
+ "post_processors/governor_shlib.cc",
+ "post_processors/governor_shlib.h",
+ ]
deps = [
":slew_volume",
"//base",
"//chromecast/base",
"//chromecast/public/media",
]
+ public_configs = [ "//chromecast/public:public_config" ]
bcf 2017/05/03 06:14:06 Why is this needed?
bshaya 2017/05/03 16:51:55 This config adds //chromecast/public as an include
}

Powered by Google App Engine
This is Rietveld 408576698