Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

Issue 2860673002: Change all test cases to use WebViewBase instead of WebViewImpl. (Closed)
Patch Set: Address code review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
index b7503c62406e9bcd4389b6c2a1b13347b3fa287c..7d6cbf11f897a604ec6404c8de618b1884e58d6f 100644
--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
@@ -190,7 +190,7 @@ WebViewHelper::~WebViewHelper() {
Reset();
}
-WebViewImpl* WebViewHelper::InitializeWithOpener(
+WebViewBase* WebViewHelper::InitializeWithOpener(
WebFrame* opener,
bool enable_javascript,
TestWebFrameClient* web_frame_client,
@@ -205,8 +205,8 @@ WebViewImpl* WebViewHelper::InitializeWithOpener(
web_view_client = DefaultWebViewClient();
if (!web_widget_client)
web_widget_client = web_view_client->WidgetClient();
- web_view_ =
- WebViewImpl::Create(web_view_client, kWebPageVisibilityStateVisible);
+ web_view_ = static_cast<WebViewBase*>(
+ WebView::Create(web_view_client, kWebPageVisibilityStateVisible));
web_view_->GetSettings()->SetJavaScriptEnabled(enable_javascript);
web_view_->GetSettings()->SetPluginsEnabled(true);
// Enable (mocked) network loads of image URLs, as this simplifies
@@ -236,7 +236,7 @@ WebViewImpl* WebViewHelper::InitializeWithOpener(
return web_view_;
}
-WebViewImpl* WebViewHelper::Initialize(
+WebViewBase* WebViewHelper::Initialize(
bool enable_javascript,
TestWebFrameClient* web_frame_client,
TestWebViewClient* web_view_client,
@@ -247,7 +247,7 @@ WebViewImpl* WebViewHelper::Initialize(
update_settings_func);
}
-WebViewImpl* WebViewHelper::InitializeAndLoad(
+WebViewBase* WebViewHelper::InitializeAndLoad(
const std::string& url,
bool enable_javascript,
TestWebFrameClient* web_frame_client,

Powered by Google App Engine
This is Rietveld 408576698