Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2860673002: Change all test cases to use WebViewBase instead of WebViewImpl. (Closed)
Patch Set: Address code review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 5ef14d05190b922becf27266fd8bed5ea65fc0c8..9781d6b7248862225d39e6483db4a59799511593 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -273,11 +273,10 @@ class ColorOverlay final : public PageOverlay::Delegate {
WebView* WebView::Create(WebViewClient* client,
WebPageVisibilityState visibility_state) {
- // Pass the WebViewImpl's self-reference to the caller.
return WebViewImpl::Create(client, visibility_state);
}
-WebViewImpl* WebViewImpl::Create(WebViewClient* client,
+WebViewBase* WebViewImpl::Create(WebViewClient* client,
WebPageVisibilityState visibility_state) {
// Pass the WebViewImpl's self-reference to the caller.
return AdoptRef(new WebViewImpl(client, visibility_state)).LeakRef();
@@ -1774,8 +1773,8 @@ WebViewBase* WebViewBase::FromPage(Page* page) {
return WebViewImpl::FromPage(page);
}
-WebViewImpl* WebViewImpl::FromPage(Page* page) {
- return page ? static_cast<WebViewImpl*>(page->GetChromeClient().WebView())
+WebViewBase* WebViewImpl::FromPage(Page* page) {
+ return page ? static_cast<WebViewBase*>(page->GetChromeClient().WebView())
: nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698