third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp - Issue 2860673002: Change all test cases to use WebViewBase instead of WebViewImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

Issue 2860673002: Change all test cases to use WebViewBase instead of WebViewImpl. (Closed)

Patch Set: Address code review comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

index 730c101dec3464b25f4b650c82b3a13fd3223621..86c98d2c9a8c45eb71a5260195ffa73b6fcfee86 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

+++ b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

@@ -123,7 +123,7 @@ class ExternalPopupMenuTest : public ::testing::Test {

WebView()->UpdateAllLifecyclePhases();

}

- WebViewImpl* WebView() const { return helper_.WebView(); }

+ WebViewBase* WebView() const { return helper_.WebView(); }

const ExternalPopupMenuWebFrameClient& Client() const {

return web_frame_client_;

}