Change all test cases to use WebViewBase instead of WebViewImpl.

third_party/WebKit/Source/web/tests/RootScrollerTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/NodeOrString.h"
 #include "core/dom/ClientRect.h"
 #include "core/frame/BrowserControls.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/RootFrameViewport.h"
 #include "core/frame/VisualViewport.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/layout/LayoutBox.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/layout/compositing/CompositedLayerMapping.h"
 #include "core/layout/compositing/PaintLayerCompositor.h"
 #include "core/page/Page.h"
 #include "core/page/scrolling/RootScrollerController.h"
 #include "core/page/scrolling/TopDocumentRootScrollerController.h"
 #include "core/paint/PaintLayer.h"
 #include "core/paint/PaintLayerScrollableArea.h"
 #include "platform/testing/URLTestHelpers.h"
 #include "platform/testing/UnitTestHelpers.h"
 #include "platform/wtf/Vector.h"
 #include "public/platform/Platform.h"
+#include "public/platform/WebCoalescedInputEvent.h"
 #include "public/platform/WebURLLoaderMockFactory.h"
 #include "public/web/WebConsoleMessage.h"
 #include "public/web/WebRemoteFrame.h"
 #include "public/web/WebScriptSource.h"
 #include "public/web/WebSettings.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebRemoteFrameImpl.h"
 #include "web/tests/FrameTestHelpers.h"
 
@@ skipping 14 matching lines @@
     RegisterMockedHttpURLLoad("root-scroller-child.html");
   }
 
   ~RootScrollerTest() override {
     features_backup_.restore();
     Platform::Current()
         ->GetURLLoaderMockFactory()
         ->UnregisterAllURLsAndClearMemoryCache();
   }
 
-  WebViewImpl* Initialize(const std::string& page_name,
+  WebViewBase* Initialize(const std::string& page_name,
                           FrameTestHelpers::TestWebViewClient* client) {
     return InitializeInternal(base_url_ + page_name, client);
   }
 
-  WebViewImpl* Initialize(const std::string& page_name) {
+  WebViewBase* Initialize(const std::string& page_name) {
     return InitializeInternal(base_url_ + page_name, &client_);
   }
 
-  WebViewImpl* Initialize() {
+  WebViewBase* Initialize() {
     return InitializeInternal("about:blank", &client_);
   }
 
   static void ConfigureSettings(WebSettings* settings) {
     settings->SetJavaScriptEnabled(true);
     settings->SetAcceleratedCompositingEnabled(true);
     settings->SetPreferCompositingToLCDTextEnabled(true);
     // Android settings.
     settings->SetViewportEnabled(true);
     settings->SetViewportMetaEnabled(true);
@@ skipping 10 matching lines @@
   void ExecuteScript(const WebString& code) {
     ExecuteScript(code, *MainWebFrame());
   }
 
   void ExecuteScript(const WebString& code, WebLocalFrame& frame) {
     frame.ExecuteScript(WebScriptSource(code));
     frame.View()->UpdateAllLifecyclePhases();
     RunPendingTasks();
   }
 
-  WebViewImpl* GetWebViewImpl() const { return helper_.WebView(); }
+  WebViewBase* GetWebView() const { return helper_.WebView(); }
 
   Page& GetPage() const { return *helper_.WebView()->GetPage(); }
 
   LocalFrame* MainFrame() const {
-    return GetWebViewImpl()->MainFrameImpl()->GetFrame();
+    return GetWebView()->MainFrameImpl()->GetFrame();
   }
 
-  WebLocalFrame* MainWebFrame() const {
-    return GetWebViewImpl()->MainFrameImpl();
-  }
+  WebLocalFrame* MainWebFrame() const { return GetWebView()->MainFrameImpl(); }
 
   FrameView* MainFrameView() const {
-    return GetWebViewImpl()->MainFrameImpl()->GetFrame()->View();
+    return GetWebView()->MainFrameImpl()->GetFrame()->View();
   }
 
   VisualViewport& GetVisualViewport() const {
     return GetPage().GetVisualViewport();
   }
 
   BrowserControls& GetBrowserControls() const {
     return GetPage().GetBrowserControls();
   }
 
@@ skipping 25 matching lines @@
     event.source_device = device;
     event.x = 100;
     event.y = 100;
     if (type == WebInputEvent::kGestureScrollUpdate) {
       event.data.scroll_update.delta_x = delta_x;
       event.data.scroll_update.delta_y = delta_y;
     }
     return WebCoalescedInputEvent(event);
   }
 
-  WebViewImpl* InitializeInternal(const std::string& url,
+  WebViewBase* InitializeInternal(const std::string& url,
                                   FrameTestHelpers::TestWebViewClient* client) {
     RuntimeEnabledFeatures::setSetRootScrollerEnabled(true);
 
     helper_.InitializeAndLoad(url, true, nullptr, client, nullptr,
                               &ConfigureSettings);
 
     // Initialize browser controls to be shown.
-    GetWebViewImpl()->ResizeWithBrowserControls(IntSize(400, 400), 50, true);
-    GetWebViewImpl()->GetBrowserControls().SetShownRatio(1);
+    GetWebView()->ResizeWithBrowserControls(IntSize(400, 400), 50, true);
+    GetWebView()->GetBrowserControls().SetShownRatio(1);
 
     MainFrameView()->UpdateAllLifecyclePhases();
 
-    return GetWebViewImpl();
+    return GetWebView();
   }
 
   std::string base_url_;
   FrameTestHelpers::TestWebViewClient client_;
   FrameTestHelpers::WebViewHelper helper_;
   RuntimeEnabledFeatures::Backup features_backup_;
 };
 
 // Test that no root scroller element is set if setRootScroller isn't called on
 // any elements. The document Node should be the default effective root
@@ skipping 53 matching lines @@
   Initialize("root-scroller.html", &client);
 
   Element* container = MainFrame()->GetDocument()->getElementById("container");
   MainFrame()->GetDocument()->setRootScroller(container);
   ASSERT_EQ(container, MainFrame()->GetDocument()->rootScroller());
 
   // Content is 1000x1000, WebView size is 400x400 but hiding the top controls
   // makes it 400x450 so max scroll is 550px.
   double maximum_scroll = 550;
 
-  GetWebViewImpl()->HandleInputEvent(
+  GetWebView()->HandleInputEvent(
       GenerateTouchGestureEvent(WebInputEvent::kGestureScrollBegin));
 
   {
     // Scrolling over the #container DIV should cause the browser controls to
     // hide.
     EXPECT_FLOAT_EQ(1, GetBrowserControls().ShownRatio());
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollUpdate, 0,
                                   -GetBrowserControls().Height()));
     EXPECT_FLOAT_EQ(0, GetBrowserControls().ShownRatio());
   }
 
   {
     // Make sure we're actually scrolling the DIV and not the FrameView.
-    GetWebViewImpl()->HandleInputEvent(GenerateTouchGestureEvent(
+    GetWebView()->HandleInputEvent(GenerateTouchGestureEvent(
         WebInputEvent::kGestureScrollUpdate, 0, -100));
     EXPECT_FLOAT_EQ(100, container->scrollTop());
     EXPECT_FLOAT_EQ(0, MainFrameView()->GetScrollOffset().Height());
   }
 
   {
     // Scroll 50 pixels past the end. Ensure we report the 50 pixels as
     // overscroll.
     EXPECT_CALL(client, DidOverscroll(WebFloatSize(0, 50), WebFloatSize(0, 50),
                                       WebFloatPoint(100, 100), WebFloatSize()));
-    GetWebViewImpl()->HandleInputEvent(GenerateTouchGestureEvent(
+    GetWebView()->HandleInputEvent(GenerateTouchGestureEvent(
         WebInputEvent::kGestureScrollUpdate, 0, -500));
     EXPECT_FLOAT_EQ(maximum_scroll, container->scrollTop());
     EXPECT_FLOAT_EQ(0, MainFrameView()->GetScrollOffset().Height());
     Mock::VerifyAndClearExpectations(&client);
   }
 
   {
     // Continue the gesture overscroll.
     EXPECT_CALL(client, DidOverscroll(WebFloatSize(0, 20), WebFloatSize(0, 70),
                                       WebFloatPoint(100, 100), WebFloatSize()));
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollUpdate, 0, -20));
     EXPECT_FLOAT_EQ(maximum_scroll, container->scrollTop());
     EXPECT_FLOAT_EQ(0, MainFrameView()->GetScrollOffset().Height());
     Mock::VerifyAndClearExpectations(&client);
   }
 
-  GetWebViewImpl()->HandleInputEvent(
+  GetWebView()->HandleInputEvent(
       GenerateTouchGestureEvent(WebInputEvent::kGestureScrollEnd));
 
   {
     // Make sure a new gesture scroll still won't scroll the frameview and
     // overscrolls.
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollBegin));
 
     EXPECT_CALL(client, DidOverscroll(WebFloatSize(0, 30), WebFloatSize(0, 30),
                                       WebFloatPoint(100, 100), WebFloatSize()));
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollUpdate, 0, -30));
     EXPECT_FLOAT_EQ(maximum_scroll, container->scrollTop());
     EXPECT_FLOAT_EQ(0, MainFrameView()->GetScrollOffset().Height());
     Mock::VerifyAndClearExpectations(&client);
 
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollEnd));
   }
 
   {
     // Scrolling up should show the browser controls.
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollBegin));
 
     EXPECT_FLOAT_EQ(0, GetBrowserControls().ShownRatio());
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollUpdate, 0, 30));
     EXPECT_FLOAT_EQ(0.6, GetBrowserControls().ShownRatio());
 
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollEnd));
   }
 
   // Reset manually to avoid lifetime issues with custom WebViewClient.
   helper_.Reset();
 }
 
 // Tests that removing the element that is the root scroller from the DOM tree
 // doesn't remove it as the root scroller but it does change the effective root
 // scroller.
@@ skipping 346 matching lines @@
   FrameTestHelpers::TestWebRemoteFrameClient remote_client;
   FrameTestHelpers::TestWebWidgetClient web_widget_client;
   WebFrameWidget* widget;
   WebLocalFrameImpl* local_frame;
 
   Initialize("root-scroller-iframe.html");
 
   // Initialization: Set the main frame to be a RemoteFrame and add a local
   // child.
   {
-    GetWebViewImpl()->SetMainFrame(remote_client.GetFrame());
-    WebRemoteFrame* root = GetWebViewImpl()->MainFrame()->ToWebRemoteFrame();
+    GetWebView()->SetMainFrame(remote_client.GetFrame());
+    WebRemoteFrame* root = GetWebView()->MainFrame()->ToWebRemoteFrame();
     root->SetReplicatedOrigin(SecurityOrigin::CreateUnique());
     WebFrameOwnerProperties properties;
     local_frame = FrameTestHelpers::CreateLocalChild(
         root, "frameName", nullptr, nullptr, nullptr, properties);
 
     FrameTestHelpers::LoadFrame(local_frame,
                                 base_url_ + "root-scroller-child.html");
     widget = local_frame->FrameWidget();
     widget->Resize(WebSize(400, 400));
   }
@@ skipping 139 matching lines @@
   EXPECT_FALSE(container_scroller->HorizontalScrollbar());
   EXPECT_FALSE(container_scroller->VerticalScrollbar());
   EXPECT_GT(container_scroller->MaximumScrollOffset().Width(), 0);
   EXPECT_GT(container_scroller->MaximumScrollOffset().Height(), 0);
 }
 
 TEST_F(RootScrollerTest, TopControlsAdjustmentAppliedToRootScroller) {
   Initialize();
 
   WebURL base_url = URLTestHelpers::ToKURL("http://www.test.com/");
-  FrameTestHelpers::LoadHTMLString(GetWebViewImpl()->MainFrame(),
+  FrameTestHelpers::LoadHTMLString(GetWebView()->MainFrame(),
                                    "<!DOCTYPE html>"
                                    "<style>"
                                    "  body, html {"
                                    "    width: 100%;"
                                    "    height: 100%;"
                                    "    margin: 0px;"
                                    "  }"
                                    "  #container {"
                                    "    width: 100%;"
                                    "    height: 100%;"
                                    "    overflow: auto;"
                                    "  }"
                                    "</style>"
                                    "<div id='container'>"
                                    "  <div style='height:1000px'>test</div>"
                                    "</div>",
                                    base_url);
 
-  GetWebViewImpl()->ResizeWithBrowserControls(IntSize(400, 400), 50, true);
+  GetWebView()->ResizeWithBrowserControls(IntSize(400, 400), 50, true);
   MainFrameView()->UpdateAllLifecyclePhases();
 
   Element* container = MainFrame()->GetDocument()->getElementById("container");
   MainFrame()->GetDocument()->setRootScroller(container, ASSERT_NO_EXCEPTION);
 
   ScrollableArea* container_scroller =
       static_cast<PaintInvalidationCapableScrollableArea*>(
           ToLayoutBox(container->GetLayoutObject())->GetScrollableArea());
 
   // Hide the top controls and scroll down maximally. We should account for the
   // change in maximum scroll offset due to the top controls hiding. That is,
   // since the controls are hidden, the "content area" is taller so the maximum
   // scroll offset should shrink.
   ASSERT_EQ(1000 - 400, container_scroller->MaximumScrollOffset().Height());
 
-  GetWebViewImpl()->HandleInputEvent(
+  GetWebView()->HandleInputEvent(
       GenerateTouchGestureEvent(WebInputEvent::kGestureScrollBegin));
   ASSERT_EQ(1, GetBrowserControls().ShownRatio());
-  GetWebViewImpl()->HandleInputEvent(GenerateTouchGestureEvent(
+  GetWebView()->HandleInputEvent(GenerateTouchGestureEvent(
       WebInputEvent::kGestureScrollUpdate, 0, -GetBrowserControls().Height()));
   ASSERT_EQ(0, GetBrowserControls().ShownRatio());
   EXPECT_EQ(1000 - 450, container_scroller->MaximumScrollOffset().Height());
 
-  GetWebViewImpl()->HandleInputEvent(
+  GetWebView()->HandleInputEvent(
       GenerateTouchGestureEvent(WebInputEvent::kGestureScrollUpdate, 0, -3000));
   EXPECT_EQ(1000 - 450, container_scroller->GetScrollOffset().Height());
 
-  GetWebViewImpl()->HandleInputEvent(
+  GetWebView()->HandleInputEvent(
       GenerateTouchGestureEvent(WebInputEvent::kGestureScrollEnd));
-  GetWebViewImpl()->ResizeWithBrowserControls(IntSize(400, 450), 50, false);
+  GetWebView()->ResizeWithBrowserControls(IntSize(400, 450), 50, false);
   EXPECT_EQ(1000 - 450, container_scroller->MaximumScrollOffset().Height());
 }
 
 TEST_F(RootScrollerTest, RotationAnchoring) {
   Initialize("root-scroller-rotation.html");
 
   ScrollableArea* container_scroller;
 
   {
-    GetWebViewImpl()->ResizeWithBrowserControls(IntSize(250, 1000), 0, true);
+    GetWebView()->ResizeWithBrowserControls(IntSize(250, 1000), 0, true);
     MainFrameView()->UpdateAllLifecyclePhases();
 
     Element* container =
         MainFrame()->GetDocument()->getElementById("container");
     NonThrowableExceptionState non_throw;
     MainFrame()->GetDocument()->setRootScroller(container, non_throw);
     MainFrameView()->UpdateAllLifecyclePhases();
 
     container_scroller = static_cast<PaintInvalidationCapableScrollableArea*>(
         ToLayoutBox(container->GetLayoutObject())->GetScrollableArea());
   }
 
   Element* target = MainFrame()->GetDocument()->getElementById("target");
 
   // Zoom in and scroll the viewport so that the target is fully in the
   // viewport and the visual viewport is fully scrolled within the layout
   // viepwort.
   {
     int scroll_x = 250 * 4;
     int scroll_y = 1000 * 4;
 
-    GetWebViewImpl()->SetPageScaleFactor(2);
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->SetPageScaleFactor(2);
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollBegin));
-    GetWebViewImpl()->HandleInputEvent(GenerateTouchGestureEvent(
+    GetWebView()->HandleInputEvent(GenerateTouchGestureEvent(
         WebInputEvent::kGestureScrollUpdate, -scroll_x, -scroll_y));
-    GetWebViewImpl()->HandleInputEvent(
+    GetWebView()->HandleInputEvent(
         GenerateTouchGestureEvent(WebInputEvent::kGestureScrollEnd));
 
     // The visual viewport should be 1.5 screens scrolled so that the target
     // occupies the bottom quadrant of the layout viewport.
     ASSERT_EQ((250 * 3) / 2, container_scroller->GetScrollOffset().Width());
     ASSERT_EQ((1000 * 3) / 2, container_scroller->GetScrollOffset().Height());
 
     // The visual viewport should have scrolled the last half layout viewport.
     ASSERT_EQ((250) / 2, GetVisualViewport().GetScrollOffset().Width());
     ASSERT_EQ((1000) / 2, GetVisualViewport().GetScrollOffset().Height());
   }
 
   // Now do a rotation resize.
-  GetWebViewImpl()->ResizeWithBrowserControls(IntSize(1000, 250), 50, false);
+  GetWebView()->ResizeWithBrowserControls(IntSize(1000, 250), 50, false);
   MainFrameView()->UpdateAllLifecyclePhases();
 
   // The visual viewport should remain fully filled by the target.
   ClientRect* rect = target->getBoundingClientRect();
   EXPECT_EQ(rect->left(), GetVisualViewport().GetScrollOffset().Width());
   EXPECT_EQ(rect->top(), GetVisualViewport().GetScrollOffset().Height());
 }
 
 // Tests that we don't crash if the default documentElement isn't a valid root
 // scroller. This can happen in some edge cases where documentElement isn't
@@ skipping 39 matching lines @@
   // FrameView without a layout.
   iframe->remove();
 
   EXPECT_EQ(MainFrameView()->LayoutViewportScrollableArea(),
             &MainFrameView()->GetRootFrameViewport()->LayoutViewport());
 }
 
 }  // namespace
 
 }  // namespace blink