Remove WebTouchEvent from TouchEventManager APIs

third_party/WebKit/public/platform/WebInputEvent.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 162 matching lines @@
 
     // WebTouchEvent - raw touch pointers not yet classified into gestures.
     kTouchStart,
     kTouchTypeFirst = kTouchStart,
     kTouchMove,
     kTouchEnd,
     kTouchCancel,
     kTouchScrollStarted,
     kTouchTypeLast = kTouchScrollStarted,
 
+    kPointerDown,

[mustaq, 2017/06/08 20:02:53]

Add a "section header": // WebPointerEvent: work in progress

[Navid Zolghadr, 2017/06/08 21:18:41]

Done.

+    kPointerActionFirst = kPointerDown,
+    kPointerUp,
+    kPointerMove,
+    kPointerCancel,
+    kPointerActionLast = kPointerCancel,

[mustaq, 2017/06/08 20:02:53]

s/kPointerAction.../kPointerType.../?  Existing blink::PointerType is a concern
but its too different in meaning to be confusing IMO.

[Navid Zolghadr, 2017/06/08 21:18:41]

Done.

+
     kTypeLast = kTouchTypeLast
   };
 
   // The modifier constants cannot change their values since pepper
   // does a 1-1 mapping of its values; see
   // content/renderer/pepper/event_conversion.cc
   //
   // A Java counterpart will be generated for this enum.
   // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.blink_public.web
   // GENERATED_JAVA_CLASS_NAME_OVERRIDE: WebInputEventModifier
@@ skipping 109 matching lines @@
 
   bool IsSameEventClass(const WebInputEvent& other) const {
     if (IsMouseEventType(type_))
       return IsMouseEventType(other.type_);
     if (IsGestureEventType(type_))
       return IsGestureEventType(other.type_);
     if (IsTouchEventType(type_))
       return IsTouchEventType(other.type_);
     if (IsKeyboardEventType(type_))
       return IsKeyboardEventType(other.type_);
     return type_ == other.type_;

[mustaq, 2017/06/08 20:02:53]

Let's update this after adding a method IsPointerEventType().

[Navid Zolghadr, 2017/06/08 21:18:41]

Done.

   }
 
   // Returns true if the WebInputEvent |type| is a pinch gesture event.
   static bool IsPinchGestureEventType(WebInputEvent::Type type) {
     return kGesturePinchTypeFirst <= type && type <= kGesturePinchTypeLast;
   }
 
   static const char* GetName(WebInputEvent::Type type) {
 #define CASE_TYPE(t)        \
   case WebInputEvent::k##t: \
@@ skipping 25 matching lines @@
       CASE_TYPE(GestureTwoFingerTap);
       CASE_TYPE(GestureLongPress);
       CASE_TYPE(GestureLongTap);
       CASE_TYPE(GesturePinchBegin);
       CASE_TYPE(GesturePinchEnd);
       CASE_TYPE(GesturePinchUpdate);
       CASE_TYPE(TouchStart);
       CASE_TYPE(TouchMove);
       CASE_TYPE(TouchEnd);
       CASE_TYPE(TouchCancel);
       CASE_TYPE(TouchScrollStarted);

[mustaq, 2017/06/08 20:02:53]

Please add the new event types here.

Getting rid of the default case below is better?  So that the compiler could
catch any missing entry?

[Navid Zolghadr, 2017/06/08 21:18:41]

Done.

       default:
         NOTREACHED();
         return "";
     }
 #undef CASE_TYPE
   }
 
   float FrameScale() const { return frame_scale_; }
   void SetFrameScale(float scale) { frame_scale_ = scale; }
 
@@ skipping 61 matching lines @@
   unsigned size_;              // The size of this structure, for serialization.
   Type type_;
   int modifiers_;
 };
 
 #pragma pack(pop)
 
 }  // namespace blink
 
 #endif