Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 286063007: Simplify PointerCompare a little (Closed)

Created:
6 years, 7 months ago by mdempsky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Simplify PointerCompare a little Technically makes a few behavioral changes, but these shouldn't have any real consequences: 1. When comparing conditional branch statements, the 'false' jump target is now compared lexicographically before the 'true' jump target (to reduce redundancy with comparing unconditional branches). This affects block ordering slightly, but equality (which is what we really care about) remains the same. 2. Adds a bit more sanity checking: RET and JMP instructions should only occur at the end of basic blocks. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -66 lines) Patch
M sandbox/linux/seccomp-bpf/codegen.cc View 1 chunk +60 lines, -66 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mdempsky
Found myself looking at this code over the weekend again and couldn't resist the urge ...
6 years, 7 months ago (2014-05-19 17:51:02 UTC) #1
jln (very slow on Chromium)
This is much better. My head hurts slightly now, but lgtm.
6 years, 7 months ago (2014-05-20 00:41:03 UTC) #2
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 7 months ago (2014-05-20 00:42:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/286063007/1
6 years, 7 months ago (2014-05-20 00:43:49 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 06:34:27 UTC) #5
Message was sent while issue was closed.
Change committed as 271593

Powered by Google App Engine
This is Rietveld 408576698