Move active field trial API to variations component.

Move active field trial API to variations component.

BUG=374297
TBR=mpearson@chromium.org,jhawkins@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271423

[Alexei Svitkine (slow), 2014-05-19 12:10:26]

Sorry for sending this prematurely. It should be ready for review now, though.
:)

[Ilya Sherman, 2014-05-19 12:29:42]

https://codereview.chromium.org/286063004/diff/20001/components/variations/va...
File components/variations/variations_associated_data.h (right):

https://codereview.chromium.org/286063004/diff/20001/components/variations/va...
components/variations/variations_associated_data.h:12: #include
"components/variations/active_field_trials.h"
nit: Can this be moved into the .cc file?

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
File components/variations/active_field_trials.cc (right):

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials.cc:52: std::vector<std::string>*
output) {
nit: I think this fits on the previous line.  Might be worth running "git cl
format".

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials.cc:63: // They simply wrap existing
functions in this file.
nit: Probably not necessary to duplicate this comment from the header file.

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
File components/variations/active_field_trials.h (right):

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials.h:13: namespace chrome_variations {
nit: Please update the namespace.

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials.h:37: };
Can this be moved into the variations_associated_data implementation file?

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
File components/variations/active_field_trials_unittest.cc (right):

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials_unittest.cc:49: }
It's too bad that this looks like a new file rather than giving a diff relative
to the old one.  It's probably not worth spending too much time on, but would be
nice if a lower --similarity threshold could capture that.

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials_unittest.cc:51: }  // namespace
chrome_variations
nit: Please update the namespace.

[Alexei Svitkine (slow), 2014-05-19 12:50:46]

https://codereview.chromium.org/286063004/diff/20001/components/variations/va...
File components/variations/variations_associated_data.h (right):

https://codereview.chromium.org/286063004/diff/20001/components/variations/va...
components/variations/variations_associated_data.h:12: #include
"components/variations/active_field_trials.h"
On 2014/05/19 12:29:42, Ilya Sherman wrote:
> nit: Can this be moved into the .cc file?

Done.

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
File components/variations/active_field_trials.cc (right):

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials.cc:52: std::vector<std::string>*
output) {
On 2014/05/19 12:29:42, Ilya Sherman wrote:
> nit: I think this fits on the previous line.  Might be worth running "git cl
> format".

Done.

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials.cc:63: // They simply wrap existing
functions in this file.
On 2014/05/19 12:29:42, Ilya Sherman wrote:
> nit: Probably not necessary to duplicate this comment from the header file.

Done.

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
File components/variations/active_field_trials.h (right):

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials.h:13: namespace chrome_variations {
On 2014/05/19 12:29:42, Ilya Sherman wrote:
> nit: Please update the namespace.

Done.

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials.h:37: };
On 2014/05/19 12:29:42, Ilya Sherman wrote:
> Can this be moved into the variations_associated_data implementation file?

Unfortunately no, because it's used in the GetFieldTrialActiveGroups TEST.

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
File components/variations/active_field_trials_unittest.cc (right):

https://codereview.chromium.org/286063004/diff/60002/components/variations/ac...
components/variations/active_field_trials_unittest.cc:51: }  // namespace
chrome_variations
On 2014/05/19 12:29:42, Ilya Sherman wrote:
> nit: Please update the namespace.

Done.

[Ilya Sherman, 2014-05-19 13:00:44]

LGTM, thanks.

[Alexei Svitkine (slow), 2014-05-19 13:03:32]

TBR mpearson for trivial chrome/browser/autocomplete/... and
chrome/browser/omnibox/... include changes.

[Alexei Svitkine (slow), 2014-05-19 13:03:43]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2014-05-19 13:04:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/asvitkine@chromium.org/286063004/110001

[Mark P, 2014-05-19 13:53:37]

autocomplete and omnibox lgtm

[commit-bot: I haz the power, 2014-05-19 16:03:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[Alexei Svitkine (slow), 2014-05-19 16:10:48]

Updated some missing files including version_handler.cc in webui, for which I've
added TBR=jhawkins.

[Alexei Svitkine (slow), 2014-05-19 16:10:54]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2014-05-19 16:11:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/asvitkine@chromium.org/286063004/140001

[commit-bot: I haz the power, 2014-05-19 18:07:28]

Change committed as 271423