Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 286063003: Save ping+beacon test status in temporary directory. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Save ping+beacon test status in temporary directory. Try to address occasional Windows-only test failures by explicitly saving away the ping + beacon requests in the system temporary directory. Also make read access to the test status file a bit more robust. R= BUG=374569 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -21 lines) Patch
M LayoutTests/http/tests/navigation/resources/check-beacon.php View 2 chunks +21 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/check-ping.php View 1 chunk +15 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/save-Ping.php View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/save-beacon.php View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
sof
Please take a look. Unclear if this gets at the problem, unable to reproduce locally, ...
6 years, 7 months ago (2014-05-18 21:12:18 UTC) #1
sof
+jochen: test deflaking attempt, looks ok?
6 years, 7 months ago (2014-05-20 11:45:51 UTC) #2
jochen (gone - plz use gerrit)
+mkwst who had similar problems with CSP iirc
6 years, 7 months ago (2014-05-21 09:22:17 UTC) #3
Mike West
On 2014/05/21 09:22:17, jochen wrote: > +mkwst who had similar problems with CSP iirc I ...
6 years, 7 months ago (2014-05-21 09:32:46 UTC) #4
sof
On 2014/05/21 09:32:46, Mike West wrote: > On 2014/05/21 09:22:17, jochen wrote: > > +mkwst ...
6 years, 7 months ago (2014-05-21 09:37:54 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-21 09:37:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/286063003/1
6 years, 7 months ago (2014-05-21 09:39:16 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 22:02:35 UTC) #8
Message was sent while issue was closed.
Change committed as 174484

Powered by Google App Engine
This is Rietveld 408576698