Refactoring DownloadManager::DownloadURL to add proper annotation.

content/public/browser/download_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active browser context in Chrome.
 //
 // Download observers:
@@ skipping 22 matching lines @@
 #include <vector>
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/sequenced_task_runner_helpers.h"
 #include "base/time/time.h"
 #include "content/public/browser/download_interrupt_reasons.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_url_parameters.h"
 #include "net/base/net_errors.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 
 class GURL;
 
 namespace content {
 
 class BrowserContext;
 class ByteStreamReader;
 class DownloadManagerDelegate;
 struct DownloadCreateInfo;
 
@@ skipping 61 matching lines @@
   // the given time constraints - after remove_begin (inclusive) and before
   // remove_end (exclusive). You may pass in null Time values to do an unbounded
   // delete in either direction.
   virtual int RemoveDownloadsByURLAndTime(
       const base::Callback<bool(const GURL&)>& url_filter,
       base::Time remove_begin,
       base::Time remove_end) = 0;
 
   // See DownloadUrlParameters for details about controlling the download.
   virtual void DownloadUrl(
-      std::unique_ptr<DownloadUrlParameters> parameters) = 0;
+      std::unique_ptr<DownloadUrlParameters> parameters,
+      const net::NetworkTrafficAnnotationTag& traffic_annotation) = 0;

[David Trainor- moved to gerrit, 2017/05/30 16:35:57]

Should the be part of DownloadUrlParameters?  We can default it to
NO_TRAFFIC_ANNOTATION_YET.  I don't feel too strongly either way, especially
since we're going to mandate this for every request, but it might make the
plumbing cleaner.

[Ramin Halavati, 2017/05/31 05:16:01]

We will gradually remove all NO_TRAFFIC_ANNOTATION_YET tags, they are temporary
until all call sites are properly annotated.
I am also not strongly towards current approach, but this is more similar to the
rest of repository and if we add a default UNASSIGNED value, we would need to
have online checks to find if it is properly annotated.

 
   // Allow objects to observe the download creation process.
   virtual void AddObserver(Observer* observer) = 0;
 
   // Remove a download observer from ourself.
   virtual void RemoveObserver(Observer* observer) = 0;
 
   // Called by the embedder, after creating the download manager, to let it know
   // about downloads from previous runs of the browser.
   virtual DownloadItem* CreateDownloadItem(
@@ skipping 54 matching lines @@
   // if you need to keep track of a specific download. (http://crbug.com/593020)
   virtual DownloadItem* GetDownload(uint32_t id) = 0;
 
   // Get the download item for |guid|.
   virtual DownloadItem* GetDownloadByGuid(const std::string& guid) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOWNLOAD_MANAGER_H_