Properly check visibility of check_connection_header

chrome/browser/net/errorpage_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 87 matching lines @@
       "var textContent = document.body.innerText.toLowerCase();"
       "var hasText = textContent.indexOf('%s'.toLowerCase()) >= 0;"
       "domAutomationController.send(hasText);",
       text.c_str());
   bool result = false;
   EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
       browser->tab_strip_model()->GetActiveWebContents(), command, &result));
   return result;
 }
 
+// Returns true if #details is displayed on the page |browser| is currently
+// displaying.
+bool WARN_UNUSED_RESULT IsDisplayingDetails(Browser* browser) {

[mmenke, 2017/05/03 15:10:59]

Could we instead make IsDiplayingText check if any parent node of the one
displaying the text has the hidden tag?  I'm concerned about this regressing and
silently causing tests to pass, particularly since it's only used twice.

[Nate Fischer, 2017/05/03 17:54:43]

In general, it seems rather difficult to get a node (and therefore parent nodes)
by innerText. For Safe Browsing, we look up nodes by ID:
https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/safe_browsi...

Unfortunately, this particular chunk of text doesn't have an associated ID. So
we'd first need to change the tests to check elements with IDs, in addition to
adding code to recursively check parent nodes. Is that the route we want to go?

[mmenke, 2017/05/04 19:03:33]

I don't suppose something like this would work:

var node = document.evaluate("//div[contains(text(),'ERR_FAILED')]", document,
null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;
domAutomationController.send(node && !node.classList.contains('hidden'))

If we're hiding a higher level node, we could also traverse the node hierarchy
upwards from the node we find, which will be the innermost one.

+  std::string command = R"(
+      var node = document.getElementById('details');
+      var isVisible = !node.classList.contains('hidden');
+      domAutomationController.send(isVisible);
+  )";
+  bool result = false;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
+      browser->tab_strip_model()->GetActiveWebContents(), command, &result));
+  return result;
+}
+
 // Expands the more box on the currently displayed error page.
 void ToggleHelpBox(Browser* browser) {
   EXPECT_TRUE(content::ExecuteScript(
       browser->tab_strip_model()->GetActiveWebContents(),
       "document.getElementById('details-button').click();"));
 }
 
 // Returns true if the diagnostics link suggestion is displayed.
 bool WARN_UNUSED_RESULT IsDisplayingDiagnosticsLink(Browser* browser) {
   std::string command = base::StringPrintf(
@@ skipping 998 matching lines @@
   GURL test_url("http://error.page.auto.reload");
   const int kRequestsToFail = 3;
   InstallInterceptor(test_url, kRequestsToFail);
   ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
       browser(), test_url, 2);
 
   EXPECT_EQ(2, interceptor()->failures());
   EXPECT_EQ(2, interceptor()->requests());
 
   ToggleHelpBox(browser());
-  EXPECT_TRUE(IsDisplayingText(browser(), l10n_util::GetStringUTF8(
-      IDS_ERRORPAGES_SUGGESTION_CHECK_CONNECTION_HEADER)));
+  EXPECT_TRUE(
+      IsDisplayingText(
+          browser(), l10n_util::GetStringUTF8(
+                         IDS_ERRORPAGES_SUGGESTION_CHECK_CONNECTION_HEADER)) &&
+      IsDisplayingDetails(browser()));
 
   content::WebContents* web_contents =
     browser()->tab_strip_model()->GetActiveWebContents();
   content::TestNavigationObserver nav_observer(web_contents, 1);
   web_contents->GetMainFrame()->ExecuteJavaScriptForTests(
       base::ASCIIToUTF16("document.getElementById('reload-button').click();"));
   nav_observer.Wait();
-  EXPECT_FALSE(IsDisplayingText(browser(), l10n_util::GetStringUTF8(
-      IDS_ERRORPAGES_SUGGESTION_CHECK_CONNECTION_HEADER)));
+  EXPECT_FALSE(
+      IsDisplayingText(
+          browser(), l10n_util::GetStringUTF8(
+                         IDS_ERRORPAGES_SUGGESTION_CHECK_CONNECTION_HEADER)) &&
+      IsDisplayingDetails(browser()));
 }
 
 // Make sure that a same document navigation does not cause issues with the
 // auto-reload timer.  Note that this test was added due to this case causing
 // a crash.  On regression, this test may hang due to a crashed renderer.
 IN_PROC_BROWSER_TEST_F(ErrorPageAutoReloadTest, IgnoresSameDocumentNavigation) {
   GURL test_url("http://error.page.auto.reload");
   InstallInterceptor(test_url, 2);
 
   // Wait for the error page and first autoreload, which happens immediately.
@@ skipping 386 matching lines @@
                        Http09WeirdPortEnabled) {
   const char kHttp09Response[] = "JumboShrimp";
   ASSERT_TRUE(embedded_test_server()->Start());
   ui_test_utils::NavigateToURL(
       browser(), embedded_test_server()->GetURL(std::string("/echo-raw?") +
                                                 kHttp09Response));
   EXPECT_TRUE(IsDisplayingText(browser(), kHttp09Response));
 }
 
 }  // namespace