chrome/browser/browsing_data/cache_counter.h - Issue 2860573004: [Offline Pages] Add cached offline page utils and show usage in settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/cache_counter.h

Issue 2860573004: [Offline Pages] Add cached offline page utils and show usage in settings. (Closed)

Patch Set: fixed unit tests but CBD tests flaky. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browsing_data/cache_counter.h

diff --git a/chrome/browser/browsing_data/cache_counter.h b/chrome/browser/browsing_data/cache_counter.h

index 3b4d4d28ce945e51c28602e1a8fbfd563ca7c948..c3c47fabd755c4c3344abfdcb702dd21bb66b181 100644

--- a/chrome/browser/browsing_data/cache_counter.h

+++ b/chrome/browser/browsing_data/cache_counter.h

@@ -42,7 +42,10 @@ class CacheCounter : public browsing_data::BrowsingDataCounter {

private:

void Count() override;

- void OnCacheSizeCalculated(int64_t bytes, bool is_upper_limit);

+ void OnCacheSizeCalculated(int64_t cache_bytes, bool is_upper_limit);

+ void OnOfflinePageSizeCalculated(int64_t cache_bytes,

+ bool is_upper_limit,

+ int64_t cached_offline_page_size);

void FetchEstimate(

base::WeakPtr<browsing_data::ConditionalCacheCountingHelper>);